relnote: A small refactoring to make RecordSpuriousRetransmission() of QuicSentPacketManager simpl…

net/quic/quic_sent_packet_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_sent_packet_manager.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/stl_util.h"
@@ skipping 374 matching lines @@
   }
   // TODO(ianswett): Currently the RTO can fire while there are pending NACK
   // retransmissions for the same data, which is not ideal.
   if (ContainsKey(pending_retransmissions_, packet_number)) {
     return;
   }
 
   pending_retransmissions_[packet_number] = transmission_type;
 }
 
+void QuicSentPacketManager::RecordOneSpuriousRetransmission(
+    const TransmissionInfo& info) {
+  stats_->bytes_spuriously_retransmitted += info.bytes_sent;
+  ++stats_->packets_spuriously_retransmitted;
+  if (debug_delegate_ != nullptr) {
+    debug_delegate_->OnSpuriousPacketRetransmission(info.transmission_type,
+                                                    info.bytes_sent);
+  }
+}
+
 void QuicSentPacketManager::RecordSpuriousRetransmissions(
     const TransmissionInfo& info,
     QuicPacketNumber acked_packet_number) {
   if (unacked_packets_.track_single_retransmission()) {
     QuicPacketNumber retransmission = info.retransmission;
     while (retransmission != 0) {
       const TransmissionInfo& retransmit_info =
           unacked_packets_.GetTransmissionInfo(retransmission);
       retransmission = retransmit_info.retransmission;
-      stats_->bytes_spuriously_retransmitted += retransmit_info.bytes_sent;
-      ++stats_->packets_spuriously_retransmitted;
-      if (debug_delegate_ != nullptr) {
-        debug_delegate_->OnSpuriousPacketRetransmission(
-            retransmit_info.transmission_type, retransmit_info.bytes_sent);
-      }
+      RecordOneSpuriousRetransmission(retransmit_info);
     }
     return;
   }
   const PacketNumberList* all_transmissions = info.all_transmissions;
   for (PacketNumberList::const_reverse_iterator it =
            all_transmissions->rbegin();
        it != all_transmissions->rend() && *it > acked_packet_number; ++it) {
     // ianswett: Prevents crash in b/20552846.
     if (*it < unacked_packets_.GetLeastUnacked() ||
         *it > unacked_packets_.largest_sent_packet()) {
       LOG(DFATAL) << "Retransmission out of range:" << *it
                   << " least unacked:" << unacked_packets_.GetLeastUnacked()
                   << " largest sent:" << unacked_packets_.largest_sent_packet();
       return;
     }
     const TransmissionInfo& retransmit_info =
         unacked_packets_.GetTransmissionInfo(*it);
 
-    stats_->bytes_spuriously_retransmitted += retransmit_info.bytes_sent;
-    ++stats_->packets_spuriously_retransmitted;
-    if (debug_delegate_ != nullptr) {
-      debug_delegate_->OnSpuriousPacketRetransmission(
-          retransmit_info.transmission_type, retransmit_info.bytes_sent);
-    }
+    RecordOneSpuriousRetransmission(retransmit_info);
   }
 }
 
 bool QuicSentPacketManager::HasPendingRetransmissions() const {
   return !pending_retransmissions_.empty();
 }
 
 QuicSentPacketManager::PendingRetransmission
 QuicSentPacketManager::NextPendingRetransmission() {
   LOG_IF(DFATAL, pending_retransmissions_.empty())
@@ skipping 551 matching lines @@
     // Rtt and cwnd do not need to be reset when the peer address change is
     // considered to be caused by NATs.
     return;
   }
 
   rtt_stats_.OnConnectionMigration();
   send_algorithm_->OnConnectionMigration();
 }
 
 }  // namespace net