Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 156663002: Use StackArgumentsAccessor to access receiver on stack, use kPCOnStackSize to (Closed)

Created:
6 years, 10 months ago by haitao.feng
Modified:
6 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Use StackArgumentsAccessor to access receiver on stack, use kPCOnStackSize to access stack argument and use movq instead of movp to operate return address on stack for x64 R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19177

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M src/x64/assembler-x64.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
args.GetReceiverOperand() and lea(name_arg, Operand(rsp, kPCOnStackSize) are necessary to "make x32.release.check" 100% pass, I have rebased ...
6 years, 10 months ago (2014-02-06 11:58:23 UTC) #1
Toon Verwaest
lgtm
6 years, 10 months ago (2014-02-06 12:00:18 UTC) #2
haitao.feng
6 years, 10 months ago (2014-02-07 02:21:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19177 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698