Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1566613002: OWNERS updates after jackhou departure. (Closed)

Created:
4 years, 11 months ago by tapted
Modified:
4 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, tapted, Matt Giuca, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OWNERS updates after jackhou departure. Jack has departed from chrome-team. Remove from OWNERS and ensure all OWNERS files have at least two OWNERS. Committed: https://crrev.com/e347da7aa08bcd58baf655e53055ed45499164eb Cr-Commit-Position: refs/heads/master@{#367773}

Patch Set 1 #

Total comments: 8

Patch Set 2 : alphabetize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M chrome/app_shim/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_shim/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/browser/api/app_current_window_internal/OWNERS View 1 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/app_window/OWNERS View 1 1 chunk +2 lines, -1 line 0 comments Download
M extensions/components/native_app_window/OWNERS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
tapted
Ben, Dom, Chris - PTAL
4 years, 11 months ago (2016-01-06 01:56:28 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566613002/1
4 years, 11 months ago (2016-01-06 01:57:50 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-06 02:15:22 UTC) #7
benwells
lgtm with nits https://codereview.chromium.org/1566613002/diff/1/chrome/app_shim/OWNERS File chrome/app_shim/OWNERS (right): https://codereview.chromium.org/1566613002/diff/1/chrome/app_shim/OWNERS#newcode2 chrome/app_shim/OWNERS:2: dominickn@chromium.org nit: alphabetical ordering https://codereview.chromium.org/1566613002/diff/1/chrome/browser/apps/app_shim/OWNERS File ...
4 years, 11 months ago (2016-01-06 03:33:25 UTC) #8
dominickn
lgtm % benwells comments.
4 years, 11 months ago (2016-01-06 03:40:46 UTC) #9
tapted
https://codereview.chromium.org/1566613002/diff/1/chrome/app_shim/OWNERS File chrome/app_shim/OWNERS (right): https://codereview.chromium.org/1566613002/diff/1/chrome/app_shim/OWNERS#newcode2 chrome/app_shim/OWNERS:2: dominickn@chromium.org On 2016/01/06 03:33:24, benwells wrote: > nit: alphabetical ...
4 years, 11 months ago (2016-01-06 04:08:59 UTC) #10
calamity
lgtm
4 years, 11 months ago (2016-01-06 04:21:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566613002/20001
4 years, 11 months ago (2016-01-06 04:23:01 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-06 04:45:56 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 04:46:57 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e347da7aa08bcd58baf655e53055ed45499164eb
Cr-Commit-Position: refs/heads/master@{#367773}

Powered by Google App Engine
This is Rietveld 408576698