Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: mojo/message_pump/handle_watcher.cc

Issue 1566573002: Fix race on mojo message pump shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-waitset-message-pump
Patch Set: Revert stuff. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/threading/thread_restrictions.h ('k') | mojo/message_pump/message_pump_mojo.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/message_pump/handle_watcher.cc
diff --git a/mojo/message_pump/handle_watcher.cc b/mojo/message_pump/handle_watcher.cc
index dbc20eb7992d11a12ab7f2ff6209b0e4b9a63d59..97d6d8856606d732607c2af3c38ae97b144c01b4 100644
--- a/mojo/message_pump/handle_watcher.cc
+++ b/mojo/message_pump/handle_watcher.cc
@@ -275,11 +275,6 @@ void WatcherThreadManager::AddRequest(const RequestData& data) {
return;
}
- // With the new Mojo EDK, the MojoMessagePump will destruct when it sees that
- // the IO thread has gone away. So at shutdown this can be null.
- if (!thread_.task_runner())
- return;
-
// We outlive |thread_|, so it's safe to use Unretained() here.
thread_.task_runner()->PostTask(
FROM_HERE,
« no previous file with comments | « base/threading/thread_restrictions.h ('k') | mojo/message_pump/message_pump_mojo.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698