Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: base/message_loop/message_loop.cc

Issue 1566573002: Fix race on mojo message pump shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-waitset-message-pump
Patch Set: Revert stuff. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/threading/thread_restrictions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop/message_loop.cc
diff --git a/base/message_loop/message_loop.cc b/base/message_loop/message_loop.cc
index 13bc854b038c5990cbc94f7ca07a94435717a65a..e84765a0f7a7e022764ce0db1509f572745c51a0 100644
--- a/base/message_loop/message_loop.cc
+++ b/base/message_loop/message_loop.cc
@@ -304,12 +304,7 @@ void MessageLoop::QuitWhenIdle() {
if (run_loop_) {
run_loop_->quit_when_idle_received_ = true;
} else {
- // We don't assert that run_loop_ is valid for custom message pumps. Some,
- // for example MojoMessagePump, might have shutdown already based on other
- // shutdown signals.
- if (type_ != MessageLoop::TYPE_CUSTOM) {
- NOTREACHED() << "Must be inside Run to call Quit";
- }
+ NOTREACHED() << "Must be inside Run to call Quit";
}
}
« no previous file with comments | « no previous file | base/threading/thread_restrictions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698