Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1566563002: Vectorize CrOS window control icons. (Closed)

Created:
4 years, 11 months ago by Evan Stade
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, tfarina, tdanderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Vectorize CrOS window control icons. BUG=569067 Committed: https://crrev.com/0cf40d355f3b24fdcaf57e54050bb4fc9bb52c1d Cr-Commit-Position: refs/heads/master@{#367969}

Patch Set 1 #

Patch Set 2 : not cros-only #

Patch Set 3 : dummy GetIcon impl in TestToolbarModel #

Unified diffs Side-by-side diffs Delta from patch set Stats (+352 lines, -75 lines) Patch
M ash/ash.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ash/frame/caption_buttons/frame_caption_button.h View 4 chunks +11 lines, -3 lines 0 comments Download
M ash/frame/caption_buttons/frame_caption_button.cc View 4 chunks +10 lines, -7 lines 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view.h View 3 chunks +8 lines, -3 lines 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/frame/caption_buttons/frame_size_button_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/frame/default_header_painter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/default_header_painter.cc View 3 chunks +13 lines, -22 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 chunk +0 lines, -14 lines 0 comments Download
D ash/resources/default_100_percent/common/window_control_icon_back.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/window_control_icon_close.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/window_control_icon_close_white.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/window_control_icon_left_snapped.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/window_control_icon_left_snapped_white.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/window_control_icon_maximize.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/window_control_icon_maximize_white.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/window_control_icon_minimize.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/window_control_icon_minimize_white.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/window_control_icon_restore.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/window_control_icon_restore_white.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/window_control_icon_right_snapped.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/window_control_icon_right_snapped_white.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/window_control_icon_back.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/window_control_icon_close.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/window_control_icon_close_white.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/window_control_icon_left_snapped.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/window_control_icon_left_snapped_white.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/window_control_icon_maximize.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/window_control_icon_maximize_white.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/window_control_icon_minimize.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/window_control_icon_minimize_white.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/window_control_icon_restore.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/window_control_icon_restore_white.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/window_control_icon_right_snapped.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/window_control_icon_right_snapped_white.png View Binary file 0 comments Download
M chrome/browser/ui/toolbar/test_toolbar_model.h View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/test_toolbar_model.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_header_painter_ash.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/frame/web_app_left_header_view_ash.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/web_app_left_header_view_ash_unittest.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 2 chunks +16 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_back.icon View 1 chunk +19 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_back.1x.icon View 1 chunk +18 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_close.icon View 1 chunk +20 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_close.1x.icon View 1 chunk +20 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_left_snapped.icon View 1 chunk +16 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_left_snapped.1x.icon View 1 chunk +15 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_maximize.icon View 1 chunk +18 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_maximize.1x.icon View 1 chunk +18 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_minimize.icon View 1 chunk +11 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_minimize.1x.icon View 1 chunk +11 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_restore.icon View 1 chunk +26 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_restore.1x.icon View 1 chunk +26 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_right_snapped.icon View 1 chunk +16 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/window_control_right_snapped.1x.icon View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Evan Stade
4 years, 11 months ago (2016-01-06 00:35:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566563002/1
4 years, 11 months ago (2016-01-06 00:36:28 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/107324) linux_chromium_rel_ng on ...
4 years, 11 months ago (2016-01-06 00:55:08 UTC) #6
sky
LGTM (rubber stamp for the .icon files)
4 years, 11 months ago (2016-01-06 00:58:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566563002/40001
4 years, 11 months ago (2016-01-07 00:18:31 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-07 00:25:04 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 00:25:53 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0cf40d355f3b24fdcaf57e54050bb4fc9bb52c1d
Cr-Commit-Position: refs/heads/master@{#367969}

Powered by Google App Engine
This is Rietveld 408576698