More 0 => Scanner::kNoSourcePos.

More 0 => Scanner::kNoSourcePos.

Arguably method extractors, invoke-field dispatchers and noSuchMethod dispatchers should also have their token position as kNoSourcePos instead of 0, but this would complicate how parser initializes its token iterator, so I'm leaving them as is.

R=hausner@google.com, johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/c4480b6dedb5eca7d72da4198267001c8bea5cdf

[rmacnak, 2016-01-06 18:25:01]

rmacnak@google.com changed reviewers:
+ hausner@google.com, johnmccutchan@google.com

[Cutch, 2016-01-06 18:28:04]

lgtm but wait for Matthias

[hausner, 2016-01-06 18:42:35]

LGTM

Personally, I like >= 0 better than != kNoSourcePos.

https://codereview.chromium.org/1566553003/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1566553003/diff/20001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:4007: if (FLAG_enable_mirrors && (method->metadata_pos !=
Scanner::kNoSourcePos)) {
I would be ok with >= 0. In my mind, any position < 0 is illegal. the
kNoSourcePos is just one value representing an illegal position.

Ditto in other places.

[rmacnak, 2016-01-06 19:08:08]

https://codereview.chromium.org/1566553003/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1566553003/diff/20001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:4007: if (FLAG_enable_mirrors && (method->metadata_pos !=
Scanner::kNoSourcePos)) {
On 2016/01/06 18:42:35, hausner wrote:
> I would be ok with >= 0. In my mind, any position < 0 is illegal. the
> kNoSourcePos is just one value representing an illegal position.
> 
> Ditto in other places.

Okay, it's stricter and shorter so I'll use that.

[rmacnak, 2016-01-06 19:12:06]

Description was changed from

==========
More 0 => Scanner::kNoSourcePos.

Arguably method extractors, invoke-field dispatchers and noSuchMethod
dispatchers should also have their token position as kNoSourcePos instead of 0,
but this would complicate how parser initializes its token iterator, so I'm
leaving them as is.
==========

to

==========
More 0 => Scanner::kNoSourcePos.

Arguably method extractors, invoke-field dispatchers and noSuchMethod
dispatchers should also have their token position as kNoSourcePos instead of 0,
but this would complicate how parser initializes its token iterator, so I'm
leaving them as is.

R=hausner@google.com, johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c4480b6dedb5eca7d72da4198267001c8bea5cdf
==========

[rmacnak, 2016-01-06 19:12:07]

Committed patchset #3 (id:40001) manually as
c4480b6dedb5eca7d72da4198267001c8bea5cdf (presubmit successful).