chrome/browser/ui/views/tabs/tab.h - Issue 1566313002: Remove layout during paint in Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab.h

Issue 1566313002: Remove layout during paint in Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove extraneous changes Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/tab.h

diff --git a/chrome/browser/ui/views/tabs/tab.h b/chrome/browser/ui/views/tabs/tab.h

index 2eaea6547c16b837fb5a972713df89204bdbe867..1fe1ac48538135458f3fabe765a763d966e15e06 100644

--- a/chrome/browser/ui/views/tabs/tab.h

+++ b/chrome/browser/ui/views/tabs/tab.h

@@ -171,6 +171,9 @@ class Tab : public gfx::AnimationDelegate,

// horizontal deltas from those.

static float GetInverseDiagonalSlope();

+ // views::View:

+ void Layout() override;

private:

friend class TabTest;

friend class TabStripTest;

@@ -220,7 +223,6 @@ class Tab : public gfx::AnimationDelegate,

void ViewHierarchyChanged(

const ViewHierarchyChangedDetails& details) override;

void OnPaint(gfx::Canvas* canvas) override;

- void Layout() override;

void OnThemeChanged() override;

const char* GetClassName() const override;

bool GetTooltipText(const gfx::Point& p,