Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1566303004: Smooth scroll on Windows should respect OS level animation disabling (Closed)

Created:
4 years, 11 months ago by ymalik
Modified:
4 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, ajuma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Smooth scroll on Windows should respect OS level animation disabling This patch checks for SPI_GETCLIENTAREAANIMATION setting on Windows and disables smooth scroll accordingly. This currently only works when the setting is changed and browser is restarted. BUG=575222 Committed: https://crrev.com/fb8b964402ea87682615f5893960636bd840423d Cr-Commit-Position: refs/heads/master@{#368804}

Patch Set 1 #

Patch Set 2 : Move call to ShouldRenderRichAnimation #

Patch Set 3 : fix failing windows bot #

Patch Set 4 : set disable smooth scrolling from only one place in the browser #

Patch Set 5 : remove unused include #

Patch Set 6 : pass disable flag to InputHandlerWrapper #

Total comments: 1

Patch Set 7 : s/disable_smooth_scrolling/enable_smooth_scrolling #

Patch Set 8 : rebase master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -19 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 4 5 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_manager.h View 1 2 3 4 5 6 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_manager.cc View 1 2 3 4 5 6 3 chunks +10 lines, -5 lines 0 comments Download
M content/renderer/input/input_handler_wrapper.h View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/input/input_handler_wrapper.cc View 1 2 3 4 5 6 1 chunk +3 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/animation/animation.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 36 (12 generated)
ymalik
4 years, 11 months ago (2016-01-08 19:34:07 UTC) #4
skobes
lgtm
4 years, 11 months ago (2016-01-08 19:40:55 UTC) #5
ymalik
+avi for content/browser and ui/gfx
4 years, 11 months ago (2016-01-08 19:46:48 UTC) #7
Avi (use Gerrit)
Why do we need to disable it in two places? I expected the one in ...
4 years, 11 months ago (2016-01-08 20:07:31 UTC) #8
ymalik
On 2016/01/08 20:07:31, Avi wrote: > Why do we need to disable it in two ...
4 years, 11 months ago (2016-01-08 20:28:33 UTC) #9
Avi (use Gerrit)
On 2016/01/08 20:28:33, ymalik1 wrote: > For some reason, the call to Animation::ShouldRenderRichAnimation() doesn't work ...
4 years, 11 months ago (2016-01-08 20:38:11 UTC) #10
skobes
Maybe we can read WebPreferences::enable_scroll_animator directly from InputHandlerWrapper ctor via render_view_impl->webkit_preferences()?
4 years, 11 months ago (2016-01-08 20:51:10 UTC) #11
ymalik
On 2016/01/08 20:51:10, skobes wrote: > Maybe we can read WebPreferences::enable_scroll_animator directly from > InputHandlerWrapper ...
4 years, 11 months ago (2016-01-11 15:55:28 UTC) #12
ymalik
@avi, skobes PTAL I updated the CL to only set the setting from one place ...
4 years, 11 months ago (2016-01-11 16:09:03 UTC) #13
ymalik
On 2016/01/11 16:09:03, ymalik1 wrote: > @avi, skobes > > PTAL > > I updated ...
4 years, 11 months ago (2016-01-11 16:12:26 UTC) #14
Avi (use Gerrit)
This is a bit cleaner, and I'm OK with it (lgtm) but still have that ...
4 years, 11 months ago (2016-01-11 16:15:14 UTC) #15
ymalik
On 2016/01/11 16:15:14, Avi wrote: > This is a bit cleaner, and I'm OK with ...
4 years, 11 months ago (2016-01-11 16:20:42 UTC) #17
piman
On 2016/01/11 16:20:42, ymalik1 wrote: > On 2016/01/11 16:15:14, Avi wrote: > > This is ...
4 years, 11 months ago (2016-01-11 17:06:05 UTC) #18
ymalik
On 2016/01/11 17:06:05, piman (Slow to review) wrote: > On 2016/01/11 16:20:42, ymalik1 wrote: > ...
4 years, 11 months ago (2016-01-11 18:44:16 UTC) #19
skobes
https://codereview.chromium.org/1566303004/diff/100001/content/renderer/input/input_handler_manager.h File content/renderer/input/input_handler_manager.h (right): https://codereview.chromium.org/1566303004/diff/100001/content/renderer/input/input_handler_manager.h#newcode57 content/renderer/input/input_handler_manager.h:57: bool disable_smooth_scrolling); Can you make it a positive bool ...
4 years, 11 months ago (2016-01-11 18:47:46 UTC) #20
ymalik
On 2016/01/11 18:47:46, skobes wrote: > https://codereview.chromium.org/1566303004/diff/100001/content/renderer/input/input_handler_manager.h > File content/renderer/input/input_handler_manager.h (right): > > https://codereview.chromium.org/1566303004/diff/100001/content/renderer/input/input_handler_manager.h#newcode57 > ...
4 years, 11 months ago (2016-01-11 18:59:26 UTC) #21
skobes
lgtm
4 years, 11 months ago (2016-01-11 19:04:24 UTC) #22
Avi (use Gerrit)
Nice! And it lets you drop the flag cleanly in the future. 👍 LGTM
4 years, 11 months ago (2016-01-11 19:18:31 UTC) #23
piman
lgtm
4 years, 11 months ago (2016-01-11 19:40:54 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566303004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566303004/120001
4 years, 11 months ago (2016-01-11 23:54:06 UTC) #26
commit-bot: I haz the power
Failed to apply patch for content/renderer/render_view_impl.cc: While running git apply --index -3 -p1; error: patch ...
4 years, 11 months ago (2016-01-12 00:59:12 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566303004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566303004/140001
4 years, 11 months ago (2016-01-12 03:59:53 UTC) #32
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 11 months ago (2016-01-12 05:24:30 UTC) #34
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 05:25:37 UTC) #36
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/fb8b964402ea87682615f5893960636bd840423d
Cr-Commit-Position: refs/heads/master@{#368804}

Powered by Google App Engine
This is Rietveld 408576698