Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 1566303002: Remove use_sysroot=0 (Closed)

Created:
4 years, 11 months ago by fbarchard1
Modified:
4 years, 11 months ago
Reviewers:
harryjin, fbarchard
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Remove use_sysroot=0 use_sysroot=0 is required for webrtc on linux intel builds, but libyuv doesnt use the affected libraries, so removing this. R=harryjin@google.com, sbc@chromium.org BUG=libyuv:534, libyuv:542 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/0e462e6f450b9248a83feee50871e1ad76d317c3

Patch Set 1 #

Patch Set 2 : align stride for fmtb in unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -66 lines) Patch
M libyuv.gyp View 1 chunk +0 lines, -13 lines 0 comments Download
M source/scale_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M unit_test/convert_test.cc View 1 3 chunks +50 lines, -52 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
fbarchard1
4 years, 11 months ago (2016-01-07 23:58:54 UTC) #1
fbarchard
use_sysroot=0 appears to be unnecessary for libyuv.
4 years, 11 months ago (2016-01-08 00:08:35 UTC) #5
harryjin
lgtm
4 years, 11 months ago (2016-01-08 13:06:31 UTC) #6
fbarchard1
4 years, 11 months ago (2016-01-11 22:57:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0e462e6f450b9248a83feee50871e1ad76d317c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698