Issue 15663006: drive: Merge 'persistent' and 'tmp' directories to 'files'

Issue 15663006: drive: Merge 'persistent' and 'tmp' directories to 'files' (Closed)

Created:
7 years, 6 months ago by hashimoto

Modified:
7 years, 6 months ago

Reviewers:
satorux1, kinaba

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Merge 'persistent' and 'tmp' directories to 'files' Remove FileCacheEntry::is_present which can be replaced with "is_pinned() || is_dirty() || is_mounted()". Stop moving files between the two directories when modifying cache states. Add FileCache::MigrateFilesFromOldDirectories(). BUG=248905 TEST=unit_tests R=kinaba@chromium.org, satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206326

Patch Set 1 : #

Total comments: 5

Patch Set 2 : Address comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+254 lines, -590 lines)			Patch
M	chrome/browser/chromeos/drive/drive.proto	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache.h	View		4 chunks	+6 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache.cc	View	1	27 chunks	+103 lines, -303 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache_metadata_unittest.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache_unittest.cc	View	1	42 chunks	+138 lines, -261 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_unittest.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/test_util.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/test_util.cc	View		2 chunks	+5 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/chromeos/drive_internals.js	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/drive_internals_ui.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

kinaba

https://codereview.chromium.org/15663006/diff/26001/chrome/browser/chromeos/drive/file_cache.cc File chrome/browser/chromeos/drive/file_cache.cc (right): https://codereview.chromium.org/15663006/diff/26001/chrome/browser/chromeos/drive/file_cache.cc#newcode707 chrome/browser/chromeos/drive/file_cache.cc:707: MigrateFilesFromOldDirectories(); How about moving this migration after InitCachePaths()? https://codereview.chromium.org/15663006/diff/26001/chrome/browser/chromeos/drive/file_cache.cc#newcode746 ...

7 years, 6 months ago (2013-06-14 01:59:33 UTC) #2

hashimoto

https://codereview.chromium.org/15663006/diff/26001/chrome/browser/chromeos/drive/file_cache.cc File chrome/browser/chromeos/drive/file_cache.cc (right): https://codereview.chromium.org/15663006/diff/26001/chrome/browser/chromeos/drive/file_cache.cc#newcode707 chrome/browser/chromeos/drive/file_cache.cc:707: MigrateFilesFromOldDirectories(); On 2013/06/14 01:59:33, kinaba wrote: > How about ...

7 years, 6 months ago (2013-06-14 04:04:46 UTC) #3

hashimoto

satorux, Could you review this change as an owner of chrome/browser/resources/chromeos and chrome/browser/ui/webui/chromeos?

7 years, 6 months ago (2013-06-14 04:25:38 UTC) #5

satorux1

chrome/browser/resources/chromeos and chrome/browser/ui/webui/chromeos LGTM

7 years, 6 months ago (2013-06-14 04:28:20 UTC) #6

hashimoto

7 years, 6 months ago (2013-06-14 06:26:02 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 manually as r206326 (presubmit successful).

Expand Messages | Collapse Messages