Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1870)

Unified Diff: Source/web/WebViewImpl.h

Issue 15663005: Expand tap highlight to allow multiple highlights for touch disambiguation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/LinkHighlight.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.h
diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h
index ee059cc941cc232f0eb915146809f087554f5162..be48e4e3f4743172df7593be83eb11746be36088 100644
--- a/Source/web/WebViewImpl.h
+++ b/Source/web/WebViewImpl.h
@@ -516,7 +516,8 @@ public:
void computeScaleAndScrollForBlockRect(const WebRect& blockRect, float padding, float defaultScaleWhenAlreadyLegible, float& scale, WebPoint& scroll);
WebCore::Node* bestTapNode(const WebCore::PlatformGestureEvent& tapEvent);
- void enableTapHighlight(const WebCore::PlatformGestureEvent& tapEvent);
+ void enableTapHighlightAtPoint(const WebCore::PlatformGestureEvent& tapEvent);
+ void enableTapHighlights(Vector<WebCore::Node*>&);
void computeScaleAndScrollForFocusedNode(WebCore::Node* focusedNode, float& scale, WebCore::IntPoint& scroll, bool& needAnimation);
void animateDoubleTapZoom(const WebCore::IntPoint&);
@@ -548,7 +549,7 @@ public:
bool shouldDisableDesktopWorkarounds();
// Exposed for tests.
- LinkHighlight* linkHighlight() { return m_linkHighlight.get(); }
+ LinkHighlight* linkHighlight(int i) { return m_linkHighlights[i].get(); }
Rick Byers 2013/09/11 15:14:49 Is there code somewhere I'm missing that calls thi
WebSettingsImpl* settingsImpl();
@@ -809,7 +810,7 @@ private:
WebPoint m_globalPositionOnFlingStart;
int m_flingModifier;
bool m_flingSourceDevice;
- OwnPtr<LinkHighlight> m_linkHighlight;
+ Vector<OwnPtr<LinkHighlight> > m_linkHighlights;
OwnPtr<ValidationMessageClientImpl> m_validationMessage;
OwnPtr<FullscreenController> m_fullscreenController;
« no previous file with comments | « Source/web/LinkHighlight.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698