LayoutTests/compositing/gestures/gesture-tapHighlight-simple-multi-target.html - Issue 15663005: Expand tap highlight to allow multiple highlights for touch disambiguation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/compositing/gestures/gesture-tapHighlight-simple-multi-target.html

Issue 15663005: Expand tap highlight to allow multiple highlights for touch disambiguation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/compositing/gestures/gesture-tapHighlight-simple-multi-target.html

diff --git a/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-multi-line.html b/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-multi-target.html

similarity index 57%

copy from LayoutTests/compositing/gestures/gesture-tapHighlight-simple-multi-line.html

copy to LayoutTests/compositing/gestures/gesture-tapHighlight-simple-multi-target.html

index 5c617d84d7cbff8d86177baffe4aea9e744b42e0..8952174b682a38459b3f37ed11a47b85318af9ad 100644

--- a/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-multi-line.html

+++ b/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-multi-target.html

@@ -5,25 +5,26 @@

</head>

-<a href="" id="targetLink" style="-webkit-tap-highlight-color: rgba(0, 255, 0, 0.5)">Long Target<br>Link.</a>

+<a href="" id="targetLink1" style="-webkit-tap-highlight-color: rgba(0, 255, 0, 0.5)">Link 1</a><br>

+<a href="" id="targetLink2" style="-webkit-tap-highlight-color: rgba(0, 255, 0, 0.5)">Link 2</a>

</div>

-This test is successful if "Long Target Link" above is covered in two transparent green rectangles with square corners.

+This test is successful if "Link 1" and "Link 2" above are covered in two transparent green rectangles with square corners.

</div>

function runTest() {

- var clientRect = document.getElementById('targetLink').getBoundingClientRect();

+ var clientRect = document.getElementById('targetLink1').getBoundingClientRect();

x = (clientRect.left + clientRect.right) / 2;

- y = (clientRect.top + clientRect.bottom) / 2;

+ y = clientRect.bottom;

touchWidth = (clientRect.right - clientRect.left) / 4;

- touchHeight = (clientRect.bottom - clientRect.top) / 4;

+ touchHeight = (clientRect.bottom - clientRect.top) / 2;

if (window.testRunner) {

testRunner.dumpAsText(true);

testRunner.waitUntilDone();

}

if (window.eventSender) {

- eventSender.gestureTapDown(x, y, touchWidth, touchHeight);

+ eventSender.gestureTap(x, y, touchWidth, touchHeight);

window.setTimeout(function() { window.testRunner.notifyDone(); }, 0);

} else {

debug("This test requires DumpRenderTree.");

« no previous file with comments | « no previous file | LayoutTests/compositing/gestures/gesture-tapHighlight-simple-multi-target-expected.txt » ('j') | Source/web/WebViewImpl.h » ('J')