Source/core/page/TouchDisambiguation.cpp - Issue 15663005: Expand tap highlight to allow multiple highlights for touch disambiguation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/TouchDisambiguation.cpp

Issue 15663005: Expand tap highlight to allow multiple highlights for touch disambiguation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/WebKit/chromium/tests/LinkHighlightTest.cpp ('K') | « Source/core/page/TouchDisambiguation.h ('k') | Source/core/platform/graphics/GraphicsLayer.h » ('j') | Source/core/platform/graphics/GraphicsLayer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/TouchDisambiguation.cpp

diff --git a/Source/core/page/TouchDisambiguation.cpp b/Source/core/page/TouchDisambiguation.cpp

index b13fa18848c115f69a14132f900a94bee4eabc8c..e4a63f280feaa7fd03bd1b9444c373c632e05bd0 100644

--- a/Source/core/page/TouchDisambiguation.cpp

+++ b/Source/core/page/TouchDisambiguation.cpp

@@ -87,7 +87,7 @@ struct TouchTargetData {

float score;

};

-void findGoodTouchTargets(const IntRect& touchBox, Frame* mainFrame, Vector<IntRect>& goodTargets)

+void findGoodTouchTargets(const IntRect& touchBox, Frame* mainFrame, Vector<IntRect>& goodTargets, Vector<Node*>& highlightNodes)

{

goodTargets.clear();

@@ -143,6 +143,7 @@ void findGoodTouchTargets(const IntRect& touchBox, Frame* mainFrame, Vector<IntR

if (it->value.score < bestScore * 0.5)

continue;

goodTargets.append(it->value.windowBoundingBox);

+ highlightNodes.append(it->key);

}