Expand tap highlight to allow multiple highlights for touch disambiguation.

Source/WebKit/chromium/tests/LinkHighlightTest.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 70 matching lines @@
     {
         PlatformGestureEventBuilder platformEvent(webViewImpl->mainFrameImpl()->frameView(), touchEvent);
         EXPECT_FALSE(webViewImpl->bestTapNode(platformEvent));
     }
 
     touchEvent.y = 20;
     // Shouldn't crash.
 
     {
         PlatformGestureEventBuilder platformEvent(webViewImpl->mainFrameImpl()->frameView(), touchEvent);
-        webViewImpl->enableTapHighlight(platformEvent);
+        webViewImpl->enableTapHighlightAtPoint(platformEvent);
     }
 
-    EXPECT_TRUE(webViewImpl->linkHighlight());
-    EXPECT_TRUE(webViewImpl->linkHighlight()->contentLayer());
-    EXPECT_TRUE(webViewImpl->linkHighlight()->clipLayer());
+    EXPECT_TRUE(webViewImpl->linkHighlight(0));
+    EXPECT_TRUE(webViewImpl->linkHighlight(0)->contentLayer());
+    EXPECT_TRUE(webViewImpl->linkHighlight(0)->clipLayer());
 
     // Find a target inside a scrollable div
 
     touchEvent.y = 100;
     {
         PlatformGestureEventBuilder platformEvent(webViewImpl->mainFrameImpl()->frameView(), touchEvent);
-        webViewImpl->enableTapHighlight(platformEvent);
+        webViewImpl->enableTapHighlightAtPoint(platformEvent);
     }
 
-    ASSERT_TRUE(webViewImpl->linkHighlight());
+    ASSERT_TRUE(webViewImpl->linkHighlight(0));
 
     // Don't highlight if no "hand cursor"
     touchEvent.y = 220; // An A-link with cross-hair cursor.
     {
         PlatformGestureEventBuilder platformEvent(webViewImpl->mainFrameImpl()->frameView(), touchEvent);
-        webViewImpl->enableTapHighlight(platformEvent);
+        webViewImpl->enableTapHighlightAtPoint(platformEvent);
     }
-    ASSERT_FALSE(webViewImpl->linkHighlight());
+    ASSERT_FALSE(webViewImpl->linkHighlight(0));
 
     touchEvent.y = 260; // A text input box.
     {
         PlatformGestureEventBuilder platformEvent(webViewImpl->mainFrameImpl()->frameView(), touchEvent);
-        webViewImpl->enableTapHighlight(platformEvent);
+        webViewImpl->enableTapHighlightAtPoint(platformEvent);
     }
-    ASSERT_FALSE(webViewImpl->linkHighlight());
+    ASSERT_FALSE(webViewImpl->linkHighlight(0));
 
     webViewImpl->close();
     Platform::current()->unitTestSupport()->unregisterAllMockedURLs();
 }
 
 class FakeWebFrameClient : public WebFrameClient {
     // To make the destructor public.
 };
 
 class FakeCompositingWebViewClient : public WebViewClient {
@@ skipping 40 matching lines @@
 
     WebGestureEvent touchEvent;
     touchEvent.type = WebInputEvent::GestureTapDown;
     touchEvent.x = 20;
     touchEvent.y = 20;
 
     PlatformGestureEventBuilder platformEvent(webViewImpl->mainFrameImpl()->frameView(), touchEvent);
     Node* touchNode = webViewImpl->bestTapNode(platformEvent);
     ASSERT_TRUE(touchNode);
 
-    webViewImpl->enableTapHighlight(platformEvent);
-    ASSERT_TRUE(webViewImpl->linkHighlight());
+    webViewImpl->enableTapHighlightAtPoint(platformEvent);

[wjmaclean, 2013/06/12 15:09:06]

We should add a test that verifies that multiple highlights work, i.e. calls
enableTapHighlights.

+    ASSERT_TRUE(webViewImpl->linkHighlight(0));
 
-    GraphicsLayer* highlightLayer = webViewImpl->linkHighlight()->currentGraphicsLayerForTesting();
+    GraphicsLayer* highlightLayer = webViewImpl->linkHighlight(0)->currentGraphicsLayerForTesting();
     ASSERT_TRUE(highlightLayer);
-    EXPECT_TRUE(highlightLayer->linkHighlight());
+    EXPECT_TRUE(highlightLayer->linkHighlight(0));
 
     touchNode->remove(IGNORE_EXCEPTION);
     webViewImpl->layout();
-    EXPECT_FALSE(highlightLayer->linkHighlight());
+    EXPECT_FALSE(highlightLayer->linkHighlight(0));
 
     webViewImpl->close();
     Platform::current()->unitTestSupport()->unregisterAllMockedURLs();
 }
 
 } // namespace