Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3977)

Unified Diff: chrome/common/extensions/permissions/usb_device_permission_unittest.cc

Issue 15663003: Fixing memory leak in newly added USB device permission unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/permissions/usb_device_permission_unittest.cc
diff --git a/chrome/common/extensions/permissions/usb_device_permission_unittest.cc b/chrome/common/extensions/permissions/usb_device_permission_unittest.cc
index 81f2f228a1442043e1fd6b8c10387682059a32ff..9be080913e1576bc48f4df3a506f2e513950d9cd 100644
--- a/chrome/common/extensions/permissions/usb_device_permission_unittest.cc
+++ b/chrome/common/extensions/permissions/usb_device_permission_unittest.cc
@@ -5,6 +5,7 @@
#include <set>
#include <string>
+#include "base/memory/scoped_ptr.h"
#include "base/pickle.h"
#include "base/utf_string_conversions.h"
#include "base/values.h"
@@ -38,7 +39,7 @@ TEST(USBDevicePermissionTest, MAYBE_PermissionMessage) {
};
// Prepare data set
- base::ListValue* permission_list = new base::ListValue();
+ scoped_ptr<base::ListValue> permission_list(new base::ListValue());
permission_list->Append(
UsbDevicePermissionData(0x02ad, 0x138c).ToValue()->DeepCopy());
permission_list->Append(
@@ -48,7 +49,7 @@ TEST(USBDevicePermissionTest, MAYBE_PermissionMessage) {
UsbDevicePermission permission(
PermissionsInfo::GetInstance()->GetByID(APIPermission::kUsbDevice));
- ASSERT_TRUE(permission.FromValue(permission_list));
+ ASSERT_TRUE(permission.FromValue(permission_list.get()));
PermissionMessages messages = permission.GetMessages();
ASSERT_EQ(3U, messages.size());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698