Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1566283003: Upgrade blink side ReadPixels size validation to consider ES3 pack parameters. (Closed)

Created:
4 years, 11 months ago by Zhenyao Mo
Modified:
4 years, 11 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, vmpstr+blinkwatch_chromium.org, dshwang, jbroman, Justin Novosad, danakj, blink-reviews-platform-graphics_chromium.org, Rik, f(malita), blink-reviews, piman+watch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upgrade blink side ReadPixels size validation to consider ES3 pack parameters. Note that this CL didn't do the upgrade for unpack, although the foundation is there. BUG=563714 TEST=conformance2/reading/read-pixels-pack-parameters.html R=kbr@chromium.org,bajones@chromium.org Committed: https://crrev.com/ff942f12ced6fea94ec108035acfb15a048fe204 Cr-Commit-Position: refs/heads/master@{#368477}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -41 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 1 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 3 chunks +19 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.h View 2 chunks +17 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp View 5 chunks +99 lines, -27 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Zhenyao Mo
kbr,bajones: PTAL
4 years, 11 months ago (2016-01-08 21:29:26 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566283003/1
4 years, 11 months ago (2016-01-08 21:30:29 UTC) #3
Zhenyao Mo
On 2016/01/08 21:29:26, Zhenyao Mo wrote: > kbr,bajones: PTAL The calculation is similar to the ...
4 years, 11 months ago (2016-01-08 21:30:31 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/5759) android_chromium_gn_compile_dbg on ...
4 years, 11 months ago (2016-01-08 21:34:38 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566283003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566283003/20001
4 years, 11 months ago (2016-01-08 21:43:45 UTC) #8
Ken Russell (switch to Gerrit)
Very nice. LGTM
4 years, 11 months ago (2016-01-08 22:13:30 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-08 23:51:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566283003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566283003/20001
4 years, 11 months ago (2016-01-09 00:15:41 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-09 00:40:47 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-09 00:42:19 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ff942f12ced6fea94ec108035acfb15a048fe204
Cr-Commit-Position: refs/heads/master@{#368477}

Powered by Google App Engine
This is Rietveld 408576698