Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1566253002: Move package_manager into mojo/shell (Closed)

Created:
4 years, 11 months ago by Ben Goodger (Google)
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move package_manager into mojo/shell TBR=sky@chromium.org http://crbug.com/575308 Committed: https://crrev.com/fe999378706f8d44d983bea26d55e1457df6551a Cr-Commit-Position: refs/heads/master@{#368202}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -1195 lines) Patch
M components/web_view/test_runner/register_local_aliases.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mandoline/app/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/app/desktop/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/app/register_local_aliases.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/fetcher/about_fetcher_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/mojo_shell.gyp View 1 1 chunk +4 lines, -4 lines 0 comments Download
D mojo/package_manager/BUILD.gn View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/package_manager/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/package_manager/capability_filter_content_handler_unittest.cc View 1 chunk +0 lines, -166 lines 0 comments Download
D mojo/package_manager/content_handler_connection.h View 1 chunk +0 lines, -69 lines 0 comments Download
D mojo/package_manager/content_handler_connection.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D mojo/package_manager/content_handler_unittest.cc View 1 chunk +0 lines, -325 lines 0 comments Download
D mojo/package_manager/package_manager_impl.h View 1 chunk +0 lines, -113 lines 0 comments Download
D mojo/package_manager/package_manager_impl.cc View 1 chunk +0 lines, -247 lines 0 comments Download
M mojo/runner/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/context.h View 3 chunks +3 lines, -5 lines 0 comments Download
M mojo/runner/context.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M mojo/runner/register_local_aliases.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/runner/register_local_aliases.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/shell/package_manager/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/shell/package_manager/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/shell/package_manager/capability_filter_content_handler_unittest.cc View 7 chunks +10 lines, -11 lines 0 comments Download
A + mojo/shell/package_manager/content_handler_connection.h View 6 chunks +9 lines, -11 lines 0 comments Download
A + mojo/shell/package_manager/content_handler_connection.cc View 4 chunks +7 lines, -8 lines 0 comments Download
A + mojo/shell/package_manager/content_handler_unittest.cc View 12 chunks +34 lines, -35 lines 0 comments Download
A + mojo/shell/package_manager/package_manager_impl.h View 4 chunks +22 lines, -24 lines 0 comments Download
A + mojo/shell/package_manager/package_manager_impl.cc View 11 chunks +23 lines, -41 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566253002/20001
4 years, 11 months ago (2016-01-07 22:36:05 UTC) #2
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-07 23:49:33 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 23:51:22 UTC) #5
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fe999378706f8d44d983bea26d55e1457df6551a
Cr-Commit-Position: refs/heads/master@{#368202}

Powered by Google App Engine
This is Rietveld 408576698