Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 156623004: Positioned <legend> element should honor width: auto (Closed)

Created:
6 years, 10 months ago by pals
Modified:
6 years, 10 months ago
Reviewers:
ojan
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Positioned <legend> element should honor width: auto BUG=336176 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166856

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1 line) Patch
A LayoutTests/fast/forms/legend-absolute-position-auto-width.html View 1 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/legend-absolute-position-auto-width-expected.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
pals
This bug was introduced while fixing crbug.com/281380. It was review here https://codereview.chromium.org/24360004/. I fixed this ...
6 years, 10 months ago (2014-02-06 12:06:11 UTC) #1
ojan
The C++ side is fine. Just need to fix up the test. https://codereview.chromium.org/156623004/diff/1/LayoutTests/platform/linux/fast/forms/legend-absolute-position-auto-width-expected.txt File LayoutTests/platform/linux/fast/forms/legend-absolute-position-auto-width-expected.txt ...
6 years, 10 months ago (2014-02-08 00:12:41 UTC) #2
pals
Added the layout test file. Please review. https://codereview.chromium.org/156623004/diff/1/LayoutTests/platform/linux/fast/forms/legend-absolute-position-auto-width-expected.txt File LayoutTests/platform/linux/fast/forms/legend-absolute-position-auto-width-expected.txt (right): https://codereview.chromium.org/156623004/diff/1/LayoutTests/platform/linux/fast/forms/legend-absolute-position-auto-width-expected.txt#newcode1 LayoutTests/platform/linux/fast/forms/legend-absolute-position-auto-width-expected.txt:1: layer at ...
6 years, 10 months ago (2014-02-10 07:08:03 UTC) #3
ojan
lgtm
6 years, 10 months ago (2014-02-10 18:36:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/156623004/100001
6 years, 10 months ago (2014-02-10 18:36:54 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-10 20:18:07 UTC) #6
Message was sent while issue was closed.
Change committed as 166856

Powered by Google App Engine
This is Rietveld 408576698