Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1566203002: Only generate code for files that are specified, not their imports. (Closed)

Created:
4 years, 11 months ago by azani
Modified:
4 years, 11 months ago
Reviewers:
rudominer
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Only generate code for files that are specified, not their imports. (This is a temporary hacky solution.) BUG= #609 R=rudominer@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a8d0c1c476f3c50d335ff41502c1e34f91d1394b

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M mojo/dart/packages/mojom/lib/src/generate.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator_v2.py View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/run_code_generators.py View 1 2 3 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
azani
ptal
4 years, 11 months ago (2016-01-07 20:54:11 UTC) #2
azani
ptal
4 years, 11 months ago (2016-01-07 21:43:08 UTC) #3
rudominer
lgtm with proviso As discussed offline, this is a temporary solution. I am working on ...
4 years, 11 months ago (2016-01-07 22:25:49 UTC) #4
azani
4 years, 11 months ago (2016-01-07 23:24:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
a8d0c1c476f3c50d335ff41502c1e34f91d1394b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698