Issue 15662012: Fix mcount counter generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15662012: Fix mcount counter generation (Closed)

Created:
7 years, 6 months ago by grosse

Modified:
7 years, 6 months ago

Reviewers:
Roland McGrath

CC:
native-client-reviews_googlegroups.com, bradnelson, Nick Bray (chromium)

Base URL:
http://git.chromium.org/native_client/nacl-gcc.git@master

Visibility:
Public.

More Reviews

Description

Fix mcount counter generation When compiling with with -pg, the x86 newlib toolchain tries to use inline locations for the mcount counts. Additionally it leaves stray @ in the generated assembly. We should use the code path that avoids all of this by defining NO_PROFILE_COUNTERS. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3492 R=mcgrathr@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gcc.git;a=commit;h=f96a3cb

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	gcc/config/i386/nacl.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

grosse

7 years, 6 months ago (2013-06-12 21:14:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as rf96a3cb (presubmit successful).

Expand Messages | Collapse Messages