Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1566163003: Start testing source positions in flow graph (Closed)

Created:
4 years, 11 months ago by Cutch
Modified:
4 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Start testing source positions in flow graph - Introduce SourcePositionTest helper class with ::InstanceCallAt and ::FuzzyInstructionMatchAt utility methods. - Test one function R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/bb62d81011eddd7467d9fedfcc670bfa892aa47a

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -0 lines) Patch
A runtime/vm/flow_graph_builder_test.cc View 1 2 1 chunk +231 lines, -0 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 11 months ago (2016-01-08 01:32:30 UTC) #3
rmacnak
lgtm w/c https://codereview.chromium.org/1566163003/diff/20001/runtime/vm/flow_graph_builder_test.cc File runtime/vm/flow_graph_builder_test.cc (right): https://codereview.chromium.org/1566163003/diff/20001/runtime/vm/flow_graph_builder_test.cc#newcode189 runtime/vm/flow_graph_builder_test.cc:189: const Function& result = Function::Handle(cls.LookupDynamicFunction( LookupFunctionAllowPrivate
4 years, 11 months ago (2016-01-08 17:36:28 UTC) #4
Cutch
https://codereview.chromium.org/1566163003/diff/20001/runtime/vm/flow_graph_builder_test.cc File runtime/vm/flow_graph_builder_test.cc (right): https://codereview.chromium.org/1566163003/diff/20001/runtime/vm/flow_graph_builder_test.cc#newcode189 runtime/vm/flow_graph_builder_test.cc:189: const Function& result = Function::Handle(cls.LookupDynamicFunction( On 2016/01/08 17:36:28, rmacnak ...
4 years, 11 months ago (2016-01-08 19:03:28 UTC) #5
Cutch
4 years, 11 months ago (2016-01-08 19:09:49 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
bb62d81011eddd7467d9fedfcc670bfa892aa47a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698