Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

Issue 1566083002: Makes sure the keyboard typing isn't blocked when InputMethod::OnFocus() is not correctly called. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/base/ime/input_method_win.cc ('K') | « ui/base/ime/input_method_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
diff --git a/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc b/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
index 3cda1193d715d889eaa0a7063b20081bed50bd22..c7dee975e161a70be58bbde338cdf2b646a4b121 100644
--- a/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
+++ b/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
@@ -384,20 +384,19 @@ void DesktopNativeWidgetAura::HandleActivationChanged(bool active) {
view_for_activation = GetWidget()->GetRootView();
activation_client->ActivateWindow(
view_for_activation->GetWidget()->GetNativeView());
- // Refreshes the focus info to IMF in case that IMF cached the old info
- // about focused text input client when it was "inactive".
- GetInputMethod()->OnFocus();
}
+ // Refreshes the focus info to IMF in case that IMF cached the old info
yukawa 2016/01/07 09:23:56 (optional) I'm fine with moving those logic, but c
Shu Chen 2016/01/08 02:04:11 Done.
+ // about focused text input client when it was "inactive".
+ GetInputMethod()->OnFocus();
} else {
// If we're not active we need to deactivate the corresponding
// aura::Window. This way if a child widget is active it gets correctly
// deactivated (child widgets don't get native desktop activation changes,
// only aura activation changes).
aura::Window* active_window = activation_client->GetActiveWindow();
- if (active_window) {
+ if (active_window)
activation_client->DeactivateWindow(active_window);
- GetInputMethod()->OnBlur();
- }
+ GetInputMethod()->OnBlur();
}
}
« ui/base/ime/input_method_win.cc ('K') | « ui/base/ime/input_method_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698