Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: ui/base/ime/input_method_auralinux.cc

Issue 1566083002: Makes sure the keyboard typing isn't blocked when InputMethod::OnFocus() is not correctly called. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/base/ime/input_method_win.cc » ('j') | ui/base/ime/input_method_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_auralinux.cc
diff --git a/ui/base/ime/input_method_auralinux.cc b/ui/base/ime/input_method_auralinux.cc
index ca9931f06f777e215e9012f9da4b9f1e3bb9fdca..439c1233bedc1fb9c2a4051332a8a08b7a6aedcc 100644
--- a/ui/base/ime/input_method_auralinux.cc
+++ b/ui/base/ime/input_method_auralinux.cc
@@ -46,6 +46,16 @@ bool InputMethodAuraLinux::OnUntranslatedIMEMessage(
void InputMethodAuraLinux::DispatchKeyEvent(ui::KeyEvent* event) {
DCHECK(event->type() == ET_KEY_PRESSED || event->type() == ET_KEY_RELEASED);
DCHECK(system_toplevel_window_focused());
+ if (!system_toplevel_window_focused()) {
+ LOG(ERROR) <<
+ "Key event got without the top-level window being activated.";
sky 2016/01/07 16:24:42 Under what conditions does this happen? It seems l
Shu Chen 2016/01/08 02:04:11 Yes, exactly. crbug.com/569339 causes a lot of com
yukawa 2016/01/08 02:21:20 My understanding is the same to what Shu explained
+ // There are random issues that the keyboard typing doesn't work.
+ // The root cause might be the InputMethod::OnFocus() is not correctly
+ // called when the top-level window is activated
+ // (in DNWA::HandleActivationChanged).
+ // Calls OnFocus here to unblock the keyboard typing.
+ OnFocus();
+ }
// If no text input client, do nothing.
if (!GetTextInputClient()) {
« no previous file with comments | « no previous file | ui/base/ime/input_method_win.cc » ('j') | ui/base/ime/input_method_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698