Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: ui/base/ime/remote_input_method_win.cc

Issue 1566083002: Makes sure the keyboard typing isn't blocked when InputMethod::OnFocus() is not correctly called. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compiled. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/ime/remote_input_method_win.cc
diff --git a/ui/base/ime/remote_input_method_win.cc b/ui/base/ime/remote_input_method_win.cc
index 53f26128c09d4d2270f2b19f0493d4eee1253c19..92e4571c96a31015f0412c9072e2a1485bcb737b 100644
--- a/ui/base/ime/remote_input_method_win.cc
+++ b/ui/base/ime/remote_input_method_win.cc
@@ -15,6 +15,7 @@
#include "base/win/scoped_handle.h"
#include "ui/base/ime/input_method.h"
#include "ui/base/ime/input_method_delegate.h"
+#include "ui/base/ime/input_method_log_collector.h"
#include "ui/base/ime/input_method_observer.h"
#include "ui/base/ime/remote_input_method_delegate_win.h"
#include "ui/base/ime/text_input_client.h"
@@ -121,7 +122,8 @@ class RemoteInputMethodWin : public InputMethod,
text_input_client_(NULL),
is_candidate_popup_open_(false),
is_ime_(false),
- langid_(kFallbackLangID) {
+ langid_(kFallbackLangID),
+ log_collector_(new InputMethodLogCollector()) {
RegisterInstance(this, this);
}
@@ -330,6 +332,10 @@ class RemoteInputMethodWin : public InputMethod,
text_input_client_->InsertText(text);
}
+ InputMethodLogCollector* GetLogCollector() override {
+ return log_collector_.get();
+ }
+
bool CanSendRemoteNotification(
const TextInputClient* text_input_client) const {
return text_input_client_ &&
@@ -348,6 +354,7 @@ class RemoteInputMethodWin : public InputMethod,
bool is_candidate_popup_open_;
bool is_ime_;
LANGID langid_;
+ scoped_ptr<InputMethodLogCollector> log_collector_;
DISALLOW_COPY_AND_ASSIGN(RemoteInputMethodWin);
};

Powered by Google App Engine
This is Rietveld 408576698