Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: ui/base/ime/input_method_log_collector.h

Issue 1566083002: Makes sure the keyboard typing isn't blocked when InputMethod::OnFocus() is not correctly called. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CQ green. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/base/ime/input_method_base.cc ('k') | ui/base/ime/input_method_log_collector.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef UI_BASE_IME_INPUT_METHOD_LOG_COLLECTOR_H_
6 #define UI_BASE_IME_INPUT_METHOD_LOG_COLLECTOR_H_
7
8 #include <string>
9 #include <vector>
10
11 #include "ui/base/ime/ui_base_ime_export.h"
12
13 namespace ui {
14
15 class UI_BASE_IME_EXPORT InputMethodLogCollector {
sky 2016/01/19 16:59:21 Add a description as to what this is for, and make
Shu Chen 2016/01/20 00:31:49 Done.
16 public:
17 InputMethodLogCollector();
18 virtual ~InputMethodLogCollector();
sky 2016/01/19 16:59:21 You don't need virtual here, do you?
Shu Chen 2016/01/20 00:31:49 Done.
19 void AddString(const char* str_val);
20 void AddBoolean(bool bool_val);
21 void DumpLogs();
22 void ClearLogs();
23
24 private:
25 std::vector<const char*> logs_;
26 };
sky 2016/01/19 16:59:20 DISALLOW...
Shu Chen 2016/01/20 00:31:49 Done.
27
28 } // namespace ui
29
30 #endif // UI_BASE_IME_INPUT_METHOD_LOG_COLLECTOR_H_
OLDNEW
« no previous file with comments | « ui/base/ime/input_method_base.cc ('k') | ui/base/ime/input_method_log_collector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698