Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1566053002: Clean up FunctionLiteral AST node cruft (Closed)

Created:
4 years, 11 months ago by adamk
Modified:
4 years, 11 months ago
Reviewers:
Dan Ehrenberg, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clean up FunctionLiteral AST node cruft Removed unused name_ field, made bitfield 16-bits long, and moved it to the start of the struct, resulting in a reduction of 8 bytes on both 32 and 64-bit platforms. Most other changes (which prompted this work) are cosmetic:r - Combined redundant enums - Named enum values kConsistently - Consistently use booleans in bitfield, using enum values only for passing information into NewFunctionLiteral - Removed unneeded arguments from NewFunctionLiteral, reducing clutter at callsites - Added const correctness consistently Committed: https://crrev.com/316dc1733191538bb0df4da7dfbd7f2e6bbf2d0f Cr-Commit-Position: refs/heads/master@{#33194}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -97 lines) Patch
M src/ast/ast.h View 7 chunks +42 lines, -55 lines 0 comments Download
M src/parsing/parser.cc View 10 chunks +21 lines, -22 lines 0 comments Download
M src/parsing/parser-base.h View 7 chunks +13 lines, -14 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/parsing/preparser.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
adamk
4 years, 11 months ago (2016-01-07 02:53:25 UTC) #2
adamk
Ping? Nothing too exciting here (and no hurry), just want to make sure it's not ...
4 years, 11 months ago (2016-01-08 19:32:49 UTC) #4
Dan Ehrenberg
lgtm
4 years, 11 months ago (2016-01-08 20:08:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566053002/1
4 years, 11 months ago (2016-01-08 20:12:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 20:38:12 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 20:38:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/316dc1733191538bb0df4da7dfbd7f2e6bbf2d0f
Cr-Commit-Position: refs/heads/master@{#33194}

Powered by Google App Engine
This is Rietveld 408576698