Prepare for ICU upgrade to 56.1

Prepare for ICU upgrade to 56.1

Add scripts/udpate.sh that automates the initial check-out of a new
version of ICU.

BUG=575007
TEST=None
R=mark@chromium.org

Committed: https://chromium.googlesource.com/chromium/deps/icu/+/997bd43b260142e3e16b20b63b5c99a0c108e527

[jungshik at Google, 2016-01-07 17:56:54]

jshin@chromium.org changed reviewers:
+ mark@chromium.org

[jungshik at Google, 2016-01-07 17:56:54]

Hi Mark, can you take a look? Thanks

[Mark Mentovai, 2016-01-07 18:25:32]

https://codereview.chromium.org/1566043002/diff/20001/scripts/update.sh
File scripts/update.sh (right):

https://codereview.chromium.org/1566043002/diff/20001/scripts/update.sh#newco...
scripts/update.sh:47: sed -r -i -e '/^ac_config_files=/ s:\
layout(ex)?/Makefile::g' \
This is GNU sed usage. This won’t work on OS X, although nothing else about the
script or README.chromium indicates this limitation.

[jungshik at Google, 2016-01-07 19:33:00]

On 2016/01/07 18:25:32, Mark Mentovai wrote:
> https://codereview.chromium.org/1566043002/diff/20001/scripts/update.sh
> File scripts/update.sh (right):
> 
>
https://codereview.chromium.org/1566043002/diff/20001/scripts/update.sh#newco...
> scripts/update.sh:47: sed -r -i -e '/^ac_config_files=/ s:\
> layout(ex)?/Makefile::g' \
> This is GNU sed usage. This won’t work on OS X, although nothing else about
the
> script or README.chromium indicates this limitation.

Changed it to use a portable regex.

[Mark Mentovai, 2016-01-07 19:37:06]

https://codereview.chromium.org/1566043002/diff/60001/scripts/update.sh
File scripts/update.sh (right):

https://codereview.chromium.org/1566043002/diff/60001/scripts/update.sh#newco...
scripts/update.sh:50: sed -i -e '/^ac_config_files=/ s:\
layout\(ex\)\{0,1\}/Makefile::g' \
The -i as used here is still not really portable. Run this on a Mac and sed
takes -e as the argument to -i. For Mac, you need to say -i '', but I don’t
think that GNU sed likes that. Portably, you can say “-i .orig” and then rm
configure.orig.

[jungshik at Google, 2016-01-07 19:53:02]

On 2016/01/07 19:37:06, Mark Mentovai wrote:
> https://codereview.chromium.org/1566043002/diff/60001/scripts/update.sh
> File scripts/update.sh (right):
> 
>
https://codereview.chromium.org/1566043002/diff/60001/scripts/update.sh#newco...
> scripts/update.sh:50: sed -i -e '/^ac_config_files=/ s:\
> layout\(ex\)\{0,1\}/Makefile::g' \
> The -i as used here is still not really portable. Run this on a Mac and sed
> takes -e as the argument to -i. For Mac, you need to say -i '', but I don’t
> think that GNU sed likes that. Portably, you can say “-i .orig” and then
rm
> configure.orig.

Thanks. I didn't realize that configure-e was created when testing it on Mac. I
did what you suggested. PTAL.

[Mark Mentovai, 2016-01-07 19:54:23]

LGTM now

[jungshik at Google, 2016-01-07 19:58:23]

On 2016/01/07 19:53:02, jshin (out until Jan 3) wrote:
> On 2016/01/07 19:37:06, Mark Mentovai wrote:
> > https://codereview.chromium.org/1566043002/diff/60001/scripts/update.sh
> > File scripts/update.sh (right):
> > 
> >
>
https://codereview.chromium.org/1566043002/diff/60001/scripts/update.sh#newco...
> > scripts/update.sh:50: sed -i -e '/^ac_config_files=/ s:\
> > layout\(ex\)\{0,1\}/Makefile::g' \
> > The -i as used here is still not really portable. Run this on a Mac and sed
> > takes -e as the argument to -i. For Mac, you need to say -i '', but I don’t
> > think that GNU sed likes that. Portably, you can say “-i .orig” and
then
> rm
> > configure.orig.
> 
> Thanks. I didn't realize that configure-e was created when testing it on Mac.
I
> did what you suggested. PTAL.

Ick. GNU sed wants '-i.orig' while Mac sed wants '-i .orig'. I'm giving up
in-place editing.

[jungshik at Google, 2016-01-07 20:00:30]

On 2016/01/07 19:58:23, jshin (out until Jan 3) wrote:
> On 2016/01/07 19:53:02, jshin (out until Jan 3) wrote:
> > On 2016/01/07 19:37:06, Mark Mentovai wrote:
> > > https://codereview.chromium.org/1566043002/diff/60001/scripts/update.sh
> > > File scripts/update.sh (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1566043002/diff/60001/scripts/update.sh#newco...
> > > scripts/update.sh:50: sed -i -e '/^ac_config_files=/ s:\
> > > layout\(ex\)\{0,1\}/Makefile::g' \
> > > The -i as used here is still not really portable. Run this on a Mac and
sed
> > > takes -e as the argument to -i. For Mac, you need to say -i '', but I
don’t
> > > think that GNU sed likes that. Portably, you can say “-i .orig” and
> then
> > rm
> > > configure.orig.
> > 
> > Thanks. I didn't realize that configure-e was created when testing it on
Mac.
> I
> > did what you suggested. PTAL.
> 
> Ick. GNU sed wants '-i.orig' while Mac sed wants '-i .orig'. I'm giving up
> in-place editing.

Oh... Mac sed works with '-i.orig'.

[jungshik at Google, 2016-01-07 21:50:05]

Description was changed from

==========
Prepare for ICU upgrade to 56.1

Add scripts/udpate.sh that automates the initial check-out of a new
version of ICU.

BUG=575007
TEST=None
==========

to

==========
Prepare for ICU upgrade to 56.1

Add scripts/udpate.sh that automates the initial check-out of a new
version of ICU.

BUG=575007
TEST=None
R=mark@chromium.org

Committed:
https://chromium.googlesource.com/chromium/deps/icu/+/997bd43b260142e3e16b20b...
==========

[jungshik at Google, 2016-01-07 21:50:06]

Committed patchset #6 (id:100001) manually as
997bd43b260142e3e16b20b63b5c99a0c108e527 (presubmit successful).