Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 156603003: [Android] Lint pylib/base. (Closed)

Created:
6 years, 10 months ago by jbudorick
Modified:
6 years, 9 months ago
Reviewers:
craigdh, frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase vs tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M build/android/pylib/base/base_test_result_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M build/android/pylib/base/base_test_runner.py View 2 chunks +1 line, -6 lines 0 comments Download
M build/android/pylib/base/test_dispatcher.py View 2 chunks +4 lines, -3 lines 0 comments Download
M build/android/pylib/base/test_dispatcher_unittest.py View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jbudorick
After blowing up a number of things in the first pylint patch, I realized that ...
6 years, 10 months ago (2014-02-11 18:34:32 UTC) #1
frankf
It's a good practice to prepend "[Android]" to CL descriptions. lgtm
6 years, 10 months ago (2014-02-11 18:36:33 UTC) #2
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 10 months ago (2014-02-11 19:45:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/156603003/1
6 years, 10 months ago (2014-02-11 19:47:23 UTC) #4
jbudorick
The CQ bit was unchecked by jbudorick@chromium.org
6 years, 10 months ago (2014-02-11 20:08:01 UTC) #5
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 10 months ago (2014-02-11 20:16:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/156603003/250001
6 years, 10 months ago (2014-02-11 20:17:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/156603003/250001
6 years, 10 months ago (2014-02-11 21:30:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/156603003/250001
6 years, 10 months ago (2014-02-11 22:07:41 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 23:21:17 UTC) #10
Message was sent while issue was closed. 
Change committed as 250545

Powered by Google App Engine
This is Rietveld 408576698