Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 1566013: Fixes a problem with filename lookups when not using encoding.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 5 months ago by grmocg
Modified:
6 years, 4 months ago
Reviewers:
Mike Belshe, mbelshe
CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Fixes a problem with filename lookups when not using encoding. Small cleanups to make compilation easier elsewhere.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M net/tools/flip_server/balsa_headers.cc View 2 chunks +2 lines, -2 lines 2 comments Download
M net/tools/flip_server/flip_in_mem_edsm_server.cc View 2 chunks +9 lines, -3 lines 1 comment Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 1 (0 generated)
Mike Belshe
7 years, 5 months ago (2010-04-02 19:41:28 UTC) #1
sorry for nits - 

otherwise lgtm

http://codereview.chromium.org/1566013/diff/1/3
File net/tools/flip_server/balsa_headers.cc (right):

http://codereview.chromium.org/1566013/diff/1/3#newcode613
net/tools/flip_server/balsa_headers.cc:613: int len_converted = snprintf(buffer,
sizeof(buffer), "%ld", (long int)length);
nit: static_cast<long int>(length)

http://codereview.chromium.org/1566013/diff/1/3#newcode722
net/tools/flip_server/balsa_headers.cc:722: "%ld", (long
int)parsed_response_code);
nit: static_cast.

http://codereview.chromium.org/1566013/diff/1/2
File net/tools/flip_server/flip_in_mem_edsm_server.cc (right):

http://codereview.chromium.org/1566013/diff/1/2#newcode6
net/tools/flip_server/flip_in_mem_edsm_server.cc:6: #include <netinet/tcp.h>  //
For TCP_NODELAY on some distros, this needs to be <linux/tcp.h>
nit: 80 columns.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b