chrome/browser/password_manager/password_manager.cc - Issue 15660018: [autofill] Add support for PSL domain matching for password autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager.cc

Issue 15660018: [autofill] Add support for PSL domain matching for password autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments from palmer Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/password_manager/password_manager.cc

diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc

index d13c4ba57db2f5987723e3d7825805338bc91f11..0d237a2735e6d4bb1f3ba5b9ad4382381651200b 100644

--- a/chrome/browser/password_manager/password_manager.cc

+++ b/chrome/browser/password_manager/password_manager.cc

@@ -301,7 +301,8 @@ void PasswordManager::OnPasswordFormsRendered(

if (provisional_save_manager_->HasGeneratedPassword())

UMA_HISTOGRAM_COUNTS("PasswordGeneration.Submitted", 1);

if (provisional_save_manager_->IsNewLogin() &&

- !provisional_save_manager_->HasGeneratedPassword()) {

+ !provisional_save_manager_->HasGeneratedPassword() &&

+ !provisional_save_manager_->IsPSLOriginMatched()) {

delegate_->AddSavePasswordInfoBarIfPermitted(

provisional_save_manager_.release());

} else {