chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillListAdapter.java - Issue 15660018: [autofill] Add support for PSL domain matching for password autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillListAdapter.java

Issue 15660018: [autofill] Add support for PSL domain matching for password autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments from palmer Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/autofill_text.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java » ('j') | chrome/browser/password_manager/password_form_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillListAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillListAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillListAdapter.java

index 123db1a73b782556f1104bf5c62069cab74458c8..9cebe745f970c1da2b9b9a9f4406af617fd353a0 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillListAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillListAdapter.java

@@ -5,6 +5,7 @@

package org.chromium.chrome.browser.autofill;

import android.content.Context;

+import android.text.TextUtils;

import android.view.LayoutInflater;

import android.view.View;

import android.view.ViewGroup;

@@ -34,10 +35,16 @@ public class AutofillListAdapter extends ArrayAdapter<AutofillSuggestion> {

(LayoutInflater) mContext.getSystemService(Context.LAYOUT_INFLATER_SERVICE);

layout = inflater.inflate(R.layout.autofill_text, null);

}

- TextView nameView = (TextView) layout.findViewById(R.id.autofill_name);

- nameView.setText(getItem(position).mName);

TextView labelView = (TextView) layout.findViewById(R.id.autofill_label);

- labelView.setText(getItem(position).mLabel);

+ labelView.setText(getItem(position).mName);

+ TextView sublabelView = (TextView) layout.findViewById(R.id.autofill_sublabel);

+ CharSequence label = getItem(position).mLabel;

aurimas (slooooooooow) 2013/06/07 23:24:29 Could you also changed this to mSubLabel and the o

nyquist 2013/06/11 03:36:01 Done.

+ if (TextUtils.isEmpty(label)) {

+ sublabelView.setVisibility(View.GONE);

+ } else {

+ sublabelView.setText(label);

+ sublabelView.setVisibility(View.VISIBLE);

+ }

return layout;

}