Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: chrome/android/java/res/layout/autofill_text.xml

Issue 15660018: [autofill] Add support for PSL domain matching for password autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated regexp, sanitized result, escaped form domain and added comments. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 <!-- Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 3
4 Use of this source code is governed by a BSD-style license that can be 4 Use of this source code is governed by a BSD-style license that can be
5 found in the LICENSE file. 5 found in the LICENSE file.
6 --> 6 -->
7 7
8 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" 8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
9 android:layout_height="fill_parent" 9 android:id="@+id/autofill_menu_text"
10 android:layout_width="fill_parent" 10 android:layout_width="fill_parent"
11 android:background="#FFF" 11 android:layout_height="40dp"
12 android:orientation="horizontal"> 12 android:minHeight="40dp"
13 <TextView android:id="@+id/autofill_label" 13 android:orientation="vertical"
14 android:layout_alignParentEnd="true" 14 android:background="#FFF"
15 android:layout_width="wrap_content" 15 android:gravity="center_vertical">
16 android:layout_height="fill_parent"
17 android:padding="5dp"
18 android:textSize="18sp"
19 android:textColor="#CCC"
20 android:ellipsize="end"
21 android:singleLine="true"/>
22 <TextView android:id="@+id/autofill_name" 16 <TextView android:id="@+id/autofill_name"
aurimas (slooooooooow) 2013/06/06 16:52:26 While we are at it lets rename these TextViews to
nyquist 2013/06/07 22:51:10 Done.
23 android:layout_alignParentStart="true" 17 android:layout_alignParentStart="true"
24 android:layout_width="wrap_content" 18 android:layout_width="wrap_content"
25 android:layout_height="fill_parent" 19 android:layout_height="wrap_content"
26 android:padding="5dp" 20 android:singleLine="true"
27 android:background="#FFF" 21 android:ellipsize="end"
28 android:textSize="18sp" 22 android:textSize="18sp"
29 android:textColor="#000" 23 android:layout_marginStart="5dp"
24 android:layout_marginEnd="5dp" />
25 <TextView android:id="@+id/autofill_label"
26 android:layout_alignParentStart="true"
27 android:layout_width="wrap_content"
28 android:layout_height="wrap_content"
29 android:singleLine="true"
30 android:ellipsize="end" 30 android:ellipsize="end"
palmer 2013/06/06 21:16:42 Hmm, could long text strings cause user confusion?
nyquist 2013/06/07 22:51:10 Yes, I believe they would. Do you have any suggest
31 android:singleLine="true"/> 31 android:textSize="14sp"
32 </RelativeLayout> 32 android:layout_marginStart="5dp"
33 android:layout_marginEnd="5dp"/>
34 </LinearLayout>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698