Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: tools/tests/rebaseline.sh

Issue 15660014: rebaseline.py : add self-tests (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: add_rebaseline_selftest Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/tests/rebaseline.sh
===================================================================
--- tools/tests/rebaseline.sh (revision 9354)
+++ tools/tests/rebaseline.sh (working copy)
@@ -61,20 +61,18 @@
./run.sh
SELFTEST_RESULT=$?
+TOOLS="skdiff benchgraphs rebaseline"
epoger 2013/05/30 20:25:17 Confusingly, this tells rebaseline.sh (the script
Stephen White 2013/05/30 20:34:16 We must go deeper..
echo
if [ "$SELFTEST_RESULT" != "0" ]; then
- WHICHTOOL=skdiff
- replace_expected_with_actual
- WHICHTOOL=benchgraphs
- replace_expected_with_actual
+ for WHICHTOOL in $TOOLS; do
+ replace_expected_with_actual
+ done
echo "Self-tests still failing, you should probably run this again..."
else
- WHICHTOOL=skdiff
- svn_add_new_files
- svn_delete_old_files
- WHICHTOOL=benchgraphs
- svn_add_new_files
- svn_delete_old_files
+ for WHICHTOOL in $TOOLS; do
+ svn_add_new_files
+ svn_delete_old_files
+ done
echo "Self-tests succeeded this time, you should be done!"
fi
exit $SELFTEST_RESULT

Powered by Google App Engine
This is Rietveld 408576698