rebaseline.py : add self-tests

tools/rebaseline.py

 #!/usr/bin/python
 
 '''
 Copyright 2012 Google Inc.
 
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 '''
 
 '''
 Rebaselines the given GM tests, on all bots and all configurations.
 Must be run from the gm-expected directory.  If run from a git or SVN
 checkout, the files will be added to the staging area for commit.
 '''
 
 import argparse
 import os
 import subprocess
 import sys
-import tempfile
 
 # Mapping of gm-expectations subdir (under
 # https://skia.googlecode.com/svn/gm-expected/ )
 # to builder name (see list at http://108.170.217.252:10117/builders )
 SUBDIR_MAPPING = {
    'base-shuttle-win7-intel-float':
     'Test-Win7-ShuttleA-HD2000-x86-Release',
    'base-shuttle-win7-intel-angle':
     'Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE',
    'base-shuttle-win7-intel-directwrite':
@@ skipping 38 matching lines @@
             self._subdirs = subdirs
         self._dry_run = dry_run
         self._is_svn_checkout = (
             os.path.exists('.svn') or
             os.path.exists(os.path.join(os.pardir, '.svn')))
         self._is_git_checkout = (
             os.path.exists('.git') or
             os.path.exists(os.path.join(os.pardir, '.git')))
 
     # Execute subprocess.call(), unless dry_run is True
-    def _Call(self, cmd, stdout=None):
+    def _Call(self, cmd):
         if self._dry_run:
             print '%s' % ' '.join(cmd)
             return 0
-        if stdout:
-            return subprocess.call(cmd, stdout=stdout)
         else:
             return subprocess.call(cmd)
 
     # Rebaseline a single file.
     def _RebaselineOneFile(self, expectations_subdir, builder_name,
                            infilename, outfilename):
         url = ('http://skia-autogen.googlecode.com/svn/gm-actual/' +
                expectations_subdir + '/' + builder_name + '/' +
                expectations_subdir + '/' + infilename)
-        cmd = [ 'curl', '--fail', '--silent', url ]
-        temp = tempfile.NamedTemporaryFile()
-        ret = self._Call(cmd, stdout=temp)
+        cmd = [ 'curl', '--fail', '--silent', url, '--output', outfilename ]

[epoger, 2013/05/30 19:44:12]

Patchset 1 changes the "curl" command so that a temporary file is no longer
needed... this is necessary so that our dry_run output is deterministic.

Validated that the tool still works properly.

+        ret = self._Call(cmd)
         if ret != 0:
             print '# Couldn\'t fetch ' + url
             return
-        cmd = [ 'cp', temp.name, outfilename ]
-        self._Call(cmd);
         if self._is_svn_checkout:
             cmd = [ 'svn', 'add', '--quiet', outfilename ]
             self._Call(cmd)
             cmd = [ 'svn', 'propset', '--quiet', 'svn:mime-type', 'image/png',
                     outfilename ];
             self._Call(cmd)
         elif self._is_git_checkout:
             cmd = [ 'git', 'add', outfilename ]
             self._Call(cmd)
 
@@ skipping 51 matching lines @@
                     help='which platform subdirectories to rebaseline; ' +
                     'if unspecified, rebaseline all subdirs, same as ' +
                     '"--subdirs %s"' % ' '.join(sorted(SUBDIR_MAPPING.keys())))
 parser.add_argument('--tests', metavar='TEST', nargs='+', required=True,
                     help='which tests to rebaseline, e.g. ' +
                     '"--tests aaclip bigmatrix"')
 args = parser.parse_args()
 rebaseliner = Rebaseliner(tests=args.tests, configs=args.configs,
                           subdirs=args.subdirs, dry_run=args.dry_run)
 rebaseliner.RebaselineAll()