Issue 15660012: Add atlasing option to GameBench bench

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15660012: Add atlasing option to GameBench bench (Closed)

Created:
7 years, 6 months ago by robertphillips

Modified:
7 years, 6 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This CL adds a variant of this bench that more closely matches the flags performance benchmark (i.e., atlased bitmaprect draws, non-aligned translations and full clears).

Patch Set 2 : fix some cruft #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -26 lines)			Patch
	M	bench/GameBench.cpp	View	1	9 chunks	+120 lines, -26 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bsalomon

lgtm https://codereview.chromium.org/15660012/diff/2001/bench/GameBench.cpp File bench/GameBench.cpp (right): https://codereview.chromium.org/15660012/diff/2001/bench/GameBench.cpp#newcode255 bench/GameBench.cpp:255: fAtlasRects[x][y] = SkIRect::MakeXYWH(kAtlasSpacer + x * (kAtlasCellWidth + ...

7 years, 6 months ago (2013-05-30 18:32:17 UTC) #2

Message was sent while issue was closed.

committed as r9363

Expand Messages | Collapse Messages

Issue 15660012: Add atlasing option to GameBench bench (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix some cruft #

Messages