Better error message for running szbuild.py out of directory.

Better error message for running szbuild.py out of directory.

TEST=Run szbuild.py in a directory which does not include "native_client" as a subdirectory.
BUG=None
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=5aa4b89fd0d73350b7331ce5305584776de533ff

[Sean Klein, 2016-01-06 21:04:54]

smklein@chromium.org changed reviewers:
+ stichnot@chromium.org

[Sean Klein, 2016-01-06 21:04:54]

Improvement to the error message from our earlier conversation.

[Jim Stichnoth, 2016-01-07 01:15:59]

otherwise lgtm

https://codereview.chromium.org/1565963002/diff/1/pydir/utils.py
File pydir/utils.py (right):

https://codereview.chromium.org/1565963002/diff/1/pydir/utils.py#newcode20
pydir/utils.py:20: print "Script must be executed from within \'native_client\'
directory"
I would use one of these strings instead:

  print "Script must be executed from within 'native_client' directory"
  print 'Script must be executed from within \'native_client\' directory'
  print 'Script must be executed from within <native_client> directory'

[Sean Klein, 2016-01-07 02:17:52]

On 2016/01/07 01:15:59, stichnot wrote:
> otherwise lgtm
> 
> https://codereview.chromium.org/1565963002/diff/1/pydir/utils.py
> File pydir/utils.py (right):
> 
> https://codereview.chromium.org/1565963002/diff/1/pydir/utils.py#newcode20
> pydir/utils.py:20: print "Script must be executed from within
\'native_client\'
> directory"
> I would use one of these strings instead:
> 
>   print "Script must be executed from within 'native_client' directory"
>   print 'Script must be executed from within \'native_client\' directory'
>   print 'Script must be executed from within <native_client> directory'

Done

[Jim Stichnoth, 2016-01-10 00:52:55]

https://codereview.chromium.org/1565963002/diff/20001/pydir/utils.py
File pydir/utils.py (right):

https://codereview.chromium.org/1565963002/diff/20001/pydir/utils.py#newcode18
pydir/utils.py:18: path_list = os.getcwd().split(os.sep)
Another thought is to add a line like:

  path_list = path_list if nacl in path_list else sys.argv[0].split(os.sep)

so that it also checks argv[0] before failing.

[Sean Klein, 2016-01-11 18:29:45]

https://codereview.chromium.org/1565963002/diff/20001/pydir/utils.py
File pydir/utils.py (right):

https://codereview.chromium.org/1565963002/diff/20001/pydir/utils.py#newcode18
pydir/utils.py:18: path_list = os.getcwd().split(os.sep)
On 2016/01/10 00:52:55, stichnot wrote:
> Another thought is to add a line like:
> 
>   path_list = path_list if nacl in path_list else sys.argv[0].split(os.sep)
> 
> so that it also checks argv[0] before failing.

Done.

[Sean Klein, 2016-01-11 18:49:28]

Description was changed from

==========
Better error message for running szbuild.py out of directory.

TEST=Run szbuild.py in a directory which does not include "native_client" as a
subdirectory.
BUG=None
==========

to

==========
Better error message for running szbuild.py out of directory.

TEST=Run szbuild.py in a directory which does not include "native_client" as a
subdirectory.
BUG=None
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Sean Klein, 2016-01-11 18:49:30]

Committed patchset #3 (id:40001) manually as
5aa4b89fd0d73350b7331ce5305584776de533ff (presubmit successful).