Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: content/common/indexed_db/indexed_db_key.cc

Issue 15659013: Revert "Migrate the IndexedDB backend from Blink to Chromium" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/indexed_db/indexed_db_key.cc
diff --git a/content/common/indexed_db/indexed_db_key.cc b/content/common/indexed_db/indexed_db_key.cc
index 5019c1cdb0e572cb56ce95d8074452034131cf6f..76306fd834cd47df5028c3cfc13a27ef5057f3f1 100644
--- a/content/common/indexed_db/indexed_db_key.cc
+++ b/content/common/indexed_db/indexed_db_key.cc
@@ -4,7 +4,6 @@
#include "content/common/indexed_db/indexed_db_key.h"
-#include <string>
#include "base/logging.h"
#include "third_party/WebKit/Source/Platform/chromium/public/WebString.h"
#include "third_party/WebKit/Source/Platform/chromium/public/WebVector.h"
@@ -61,7 +60,7 @@ static IndexedDBKey::KeyArray CopyKeyArray(const WebIDBKey& other) {
}
return result;
}
-} // namespace
+} // namespace
IndexedDBKey::IndexedDBKey()
: type_(WebIDBKey::NullType),
@@ -105,8 +104,6 @@ IndexedDBKey::IndexedDBKey(const string16& key)
IndexedDBKey::~IndexedDBKey() {}
int IndexedDBKey::Compare(const IndexedDBKey& other) const {
- DCHECK(IsValid());
- DCHECK(other.IsValid());
if (type_ != other.type_)
return type_ > other.type_ ? -1 : 1;
@@ -124,17 +121,15 @@ int IndexedDBKey::Compare(const IndexedDBKey& other) const {
case WebIDBKey::StringType:
return -other.string_.compare(string_);
case WebIDBKey::DateType:
- return (date_ < other.date_) ? -1 : (date_ > other.date_) ? 1 : 0;
case WebIDBKey::NumberType:
return (number_ < other.number_) ? -1 : (number_ > other.number_) ? 1 : 0;
case WebIDBKey::InvalidType:
case WebIDBKey::NullType:
- case WebIDBKey::MinType:
+ default:
+ // This is a placeholder for WebKit::WebIDBKey::MinType
NOTREACHED();
return 0;
}
- NOTREACHED();
- return 0;
}
bool IndexedDBKey::IsLessThan(const IndexedDBKey& other) const {
@@ -145,20 +140,6 @@ bool IndexedDBKey::IsEqual(const IndexedDBKey& other) const {
return !Compare(other);
}
-bool IndexedDBKey::IsValid() const {
- if (type_ == WebIDBKey::InvalidType || type_ == WebIDBKey::NullType)
- return false;
-
- if (type_ == WebIDBKey::ArrayType) {
- for (size_t i = 0; i < array_.size(); i++) {
- if (!array_[i].IsValid())
- return false;
- }
- }
-
- return true;
-}
-
IndexedDBKey::operator WebIDBKey() const {
switch (type_) {
case WebIDBKey::ArrayType:
@@ -173,12 +154,11 @@ IndexedDBKey::operator WebIDBKey() const {
return WebIDBKey::createInvalid();
case WebIDBKey::NullType:
return WebIDBKey::createNull();
- case WebIDBKey::MinType:
+ default:
+ // This is a placeholder for WebKit::WebIDBKey::MinType
NOTREACHED();
return WebIDBKey::createInvalid();
}
- NOTREACHED();
- return WebIDBKey::createInvalid();
}
} // namespace content
« no previous file with comments | « content/browser/indexed_db/webidbfactory_impl.cc ('k') | content/common/indexed_db/indexed_db_param_traits.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698