test/Transforms/NaCl/expand-ctors-emptylist.ll - Issue 15659005: PNaCl: Fix ExpandCtors to handle an empty list case

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/Transforms/NaCl/expand-ctors-emptylist.ll

Issue 15659005: PNaCl: Fix ExpandCtors to handle an empty list case (Closed) Base URL: http://git.chromium.org/native_client/pnacl-llvm.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 ; RUN: opt %s -nacl-expand-ctors -S \| FileCheck %s -check-prefix=NO_CTORS
	jvoung (off chromium) 2013/05/22 15:47:21 Why two separate RUN invocations? Can't you just Why two separate RUN invocations? Can't you just combine them? Mark Seaborn 2013/05/22 16:30:38 It makes the test stricter. Many other tests do t Show quoted text On 2013/05/22 15:47:21, jvoung (cr) wrote: > Why two separate RUN invocations? Can't you just combine them? It makes the test stricter. Many other tests do this. "CHECK-NOT: foo" only asserts that "foo" doesn't appear between the two enclosing CHECKs within a given FileCheck invocation. Putting the CHECK-NOTs in their own FileCheck invocation ensures that the strings don't appear anywhere in the output. jvoung (off chromium) 2013/05/22 16:50:40 Ah, right... Show quoted text On 2013/05/22 16:30:38, Mark Seaborn wrote: > On 2013/05/22 15:47:21, jvoung (cr) wrote: > > Why two separate RUN invocations? Can't you just combine them? > > It makes the test stricter. Many other tests do this. > > "CHECK-NOT: foo" only asserts that "foo" doesn't appear between the two > enclosing CHECKs within a given FileCheck invocation. Putting the CHECK-NOTs in > their own FileCheck invocation ensures that the strings don't appear anywhere in > the output. Ah, right...
	2 ; NO_CTORS-NOT: __init_array_end

	3 ; NO_CTORS-NOT: __fini_array_end

	4 ; NO_CTORS-NOT: llvm.global_ctors

	5

	6 ; RUN: opt %s -nacl-expand-ctors -S \| FileCheck %s

	7

	8 ; Check that the pass works when the initializer is "[]", which gets

	9 ; converted into "undef" by the reader.

	10 @llvm.global_ctors = appending global [0 x { i32, void ()* }] []

	11

	12 ; CHECK: @__init_array_start = internal constant [0 x void ()*] zeroinitializer

	13 ; CHECK: @__fini_array_start = internal constant [0 x void ()*] zeroinitializer

OLD	NEW

« no previous file with comments | « lib/Transforms/NaCl/ExpandCtors.cpp ('k') | no next file » | no next file with comments »