third_party/WebKit/Source/web/tests/WebViewTest.cpp - Issue 1565893004: Sets a transparent background for out-of-process subframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 1565893004: Sets a transparent background for out-of-process subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/renderer/aw_render_frame_ext.cc ('K') | « third_party/WebKit/Source/web/WebViewImpl.h ('k') | third_party/WebKit/public/web/WebFrameWidget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

index 7c637ec32c45d8668e4b54f6f127da452f07bedf..791db5b6877200ddc7d2eaecbaceca527a188681 100644

--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

@@ -536,7 +536,7 @@ TEST_F(WebViewTest, SetBaseBackgroundColorBeforeMainFrame)

{

const WebColor kBlue = 0xFF0000FF;

FrameTestHelpers::TestWebViewClient webViewClient;

- WebView* webView = WebViewImpl::create(&webViewClient);

+ WebViewImpl* webView = WebViewImpl::create(&webViewClient);

EXPECT_NE(kBlue, webView->backgroundColor());

// webView does not have a frame yet, but we should still be able to set the background color.

webView->setBaseBackgroundColor(kBlue);

@@ -554,7 +554,7 @@ TEST_F(WebViewTest, SetBaseBackgroundColorAndBlendWithExistingContent)

const int kWidth = 100;

const int kHeight = 100;

- WebView* webView = m_webViewHelper.initialize();

+ WebViewImpl* webView = m_webViewHelper.initialize();

// Set WebView background to green with alpha.

webView->setBaseBackgroundColor(kAlphaGreen);