Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2156)

Unified Diff: android_webview/renderer/aw_render_frame_ext.cc

Issue 1565893004: Sets a transparent background for out-of-process subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: split cc changes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/renderer/aw_render_frame_ext.cc
diff --git a/android_webview/renderer/aw_render_frame_ext.cc b/android_webview/renderer/aw_render_frame_ext.cc
index 866dbb2cf59c42144de34444988a0a0c94c620e0..d9f33df68af73c25617cbfccc02c69ebb730a8b5 100644
--- a/android_webview/renderer/aw_render_frame_ext.cc
+++ b/android_webview/renderer/aw_render_frame_ext.cc
@@ -14,6 +14,7 @@
#include "third_party/WebKit/public/web/WebDocument.h"
#include "third_party/WebKit/public/web/WebElement.h"
#include "third_party/WebKit/public/web/WebElementCollection.h"
+#include "third_party/WebKit/public/web/WebFrameWidget.h"
#include "third_party/WebKit/public/web/WebHitTestResult.h"
#include "third_party/WebKit/public/web/WebLocalFrame.h"
#include "third_party/WebKit/public/web/WebMeaningfulLayout.h"
@@ -253,11 +254,11 @@ void AwRenderFrameExt::OnSetInitialPageScale(double page_scale_factor) {
}
void AwRenderFrameExt::OnSetBackgroundColor(SkColor c) {
- blink::WebView* webview = GetWebView();
- if (!webview)
+ blink::WebFrameWidget* webframewidget = GetWebFrameWidget();
+ if (!webframewidget)
return;
- webview->setBaseBackgroundColor(c);
+ webframewidget->setBaseBackgroundColor(c);
}
void AwRenderFrameExt::OnSmoothScroll(int target_x,
@@ -278,4 +279,11 @@ blink::WebView* AwRenderFrameExt::GetWebView() {
return render_frame()->GetRenderView()->GetWebView();
}
+blink::WebView* AwRenderFrameExt::GetWebFrameWidget() {
+ if (!render_frame() || !render_frame()->GetRenderView())
+ return nullptr;
+
+ return render_frame()->GetRenderView()->GetWebFrameWidget();
+}
+
} // namespace android_webview

Powered by Google App Engine
This is Rietveld 408576698