Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: content/renderer/media/webmediaplayer_ms_compositor.cc

Issue 1565893002: Bug Fix: WebMediaPlayerMS Crashes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disallow Copy Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/webmediaplayer_ms_compositor.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/webmediaplayer_ms_compositor.cc
diff --git a/content/renderer/media/webmediaplayer_ms_compositor.cc b/content/renderer/media/webmediaplayer_ms_compositor.cc
index ae58a3e3cf6400cc4ea55ad5cc207a0114bd8f53..166d436ba64a07778ae14031680a3dfd9f83b1c0 100644
--- a/content/renderer/media/webmediaplayer_ms_compositor.cc
+++ b/content/renderer/media/webmediaplayer_ms_compositor.cc
@@ -104,7 +104,8 @@ WebMediaPlayerMSCompositor::WebMediaPlayerMSCompositor(
last_render_length_(base::TimeDelta::FromSecondsD(1.0 / 60.0)),
total_frame_count_(0),
dropped_frame_count_(0),
- stopped_(true) {
+ stopped_(true),
+ weak_ptr_factory_(this) {
main_message_loop_ = base::MessageLoop::current();
const blink::WebMediaStream web_stream(
@@ -272,7 +273,7 @@ void WebMediaPlayerMSCompositor::StartRendering() {
DCHECK(thread_checker_.CalledOnValidThread());
compositor_task_runner_->PostTask(
FROM_HERE, base::Bind(&WebMediaPlayerMSCompositor::StartRenderingInternal,
- base::Unretained(this)));
+ weak_ptr_factory_.GetWeakPtr()));
}
void WebMediaPlayerMSCompositor::StartRenderingInternal() {
@@ -287,7 +288,7 @@ void WebMediaPlayerMSCompositor::StopRendering() {
DCHECK(thread_checker_.CalledOnValidThread());
compositor_task_runner_->PostTask(
FROM_HERE, base::Bind(&WebMediaPlayerMSCompositor::StopRenderingInternal,
- base::Unretained(this)));
+ weak_ptr_factory_.GetWeakPtr()));
}
void WebMediaPlayerMSCompositor::StopRenderingInternal() {
« no previous file with comments | « content/renderer/media/webmediaplayer_ms_compositor.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698