Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 1565873002: Update mini_chromium to a43fee120b10ed71df4e55a370948ca461d78232 (Closed)

Created:
4 years, 11 months ago by Mark Mentovai
Modified:
4 years, 11 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Update mini_chromium to a43fee120b10ed71df4e55a370948ca461d78232 a43fee120b10 Sync Mac scopers with upstream Chromium This adapts to updated Mac scopers from Chromium cfd6ed5600d8, including the changes from that commit and Chromium f39d4ffc6c32. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/b7e4564ff2194297ded7b0fd20e6b1313905df2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -48 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M util/mac/launchd.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M util/mac/launchd_test.mm View 10 chunks +34 lines, -29 lines 0 comments Download
M util/mac/service_management.cc View 5 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Mark Mentovai
4 years, 11 months ago (2016-01-06 17:27:43 UTC) #2
Robert Sesek
LGTM
4 years, 11 months ago (2016-01-06 17:28:38 UTC) #3
Mark Mentovai
4 years, 11 months ago (2016-01-06 17:32:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b7e4564ff2194297ded7b0fd20e6b1313905df2f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698