Add GetDeviceSupportedFormats to Win DirectShow.

media/video/capture/win/video_capture_device_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/video/capture/win/video_capture_device_win.h"
 
 #include <algorithm>
 #include <list>
 
 #include "base/command_line.h"
@@ skipping 132 matching lines @@
 
 // Delete a media type structure that was allocated on the heap.
 // http://msdn.microsoft.com/en-us/library/dd375432(VS.85).aspx
 void DeleteMediaType(AM_MEDIA_TYPE* mt) {
   if (mt != NULL) {
     FreeMediaType(mt);
     CoTaskMemFree(mt);
   }
 }
 
+VideoPixelFormat TranslateMediaSubtypeToPixelFormat(GUID subtype) {

[tommi (sloooow) - chröme, 2014/02/17 12:58:29]

sub_type?  Also, pass by const&?

[mcasas, 2014/02/17 14:56:20]

Done.

+  // We can't use a GUID in a switch-case, this applies to |subtype|.
+  if (subtype == kMediaSubTypeI420) {

[tommi (sloooow) - chröme, 2014/02/17 12:58:29]

I would like to see this data driven instead of multiple conditionals:

struct {
  const GUID& sub_type;
  VideoPixelFormat format;
} pixel_formats[] = {
  { kMediaSubTypeI420, PIXEL_FORMAT_I420 },
  { MEDIASUBTYPE_IYUV, PIXEL_FORMAT_I420 },
  ...
};

for (size_t i = 0; i < ARRAYSIZE_UNSAFE(pixel_formats); ++i) {
  if (sub_type == pixel_format[i].sub_type)
    return pixel_format[i].format;
}

#ifndef NDEBUG
  WCHAR guid_str[128];
  StringFromGUID2(subtype, guid_str, arraysize(guid_str));
  DVLOG(2) << "Device (also) supports an unknown media type " << guid_str;
#endif

return PIXEL_FORMAT_UNKNOWN;

[mcasas, 2014/02/17 14:56:20]

Done.

+    return PIXEL_FORMAT_I420;
+  } else if (subtype == MEDIASUBTYPE_IYUV) {
+    // This is identical to PIXEL_FORMAT_I420.
+    return PIXEL_FORMAT_I420;
+  } else if (subtype == MEDIASUBTYPE_RGB24) {
+    return PIXEL_FORMAT_RGB24;
+  } else if (subtype == MEDIASUBTYPE_YUY2) {
+    return PIXEL_FORMAT_YUY2;
+  } else if (subtype == MEDIASUBTYPE_MJPG) {
+    return PIXEL_FORMAT_MJPEG;
+  } else if (subtype == MEDIASUBTYPE_UYVY) {
+    return PIXEL_FORMAT_UYVY;
+  } else if (subtype == MEDIASUBTYPE_ARGB32) {
+    return PIXEL_FORMAT_ARGB;
+  } else {
+    WCHAR guid_str[128];
+    StringFromGUID2(subtype, guid_str, arraysize(guid_str));

[tommi (sloooow) - chröme, 2014/02/17 12:58:29]

(I know this is just moved code)
This should be inside an #ifndef NDEBUG block (see above) since otherwise it's
just code bloat.

[mcasas, 2014/02/17 14:56:20]

Done.

+    DVLOG(2) << "Device supports (also) an unknown media type " << guid_str;
+    return PIXEL_FORMAT_UNKNOWN;
+  }
+}
+
 }  // namespace
 
 // static
 void VideoCaptureDevice::GetDeviceNames(Names* device_names) {
   const CommandLine* cmd_line = CommandLine::ForCurrentProcess();
   // Use Media Foundation for Metro processes (after and including Win8) and
   // DirectShow for any other versions, unless forced via flag. Media Foundation
   // can also be forced if appropriate flag is set and we are in Windows 7 or
   // 8 in non-Metro mode.
   if ((base::win::IsMetroProcess() &&
@@ skipping 84 matching lines @@
 
     // Find the description or friendly name.
     ScopedVariant name;
     hr = prop_bag->Read(L"Description", name.Receive(), 0);
     if (FAILED(hr))
       hr = prop_bag->Read(L"FriendlyName", name.Receive(), 0);
 
     if (SUCCEEDED(hr) && name.type() == VT_BSTR) {
       // Ignore all VFW drivers and the special Google Camera Adapter.
       // Google Camera Adapter is not a real DirectShow camera device.
-      // VFW is very old Video for Windows drivers that can not be used.
+      // VFW are very old Video for Windows drivers that can not be used.
       const wchar_t* str_ptr = V_BSTR(&name);
       const int name_length = arraysize(kGoogleCameraAdapter) - 1;
 
       if ((wcsstr(str_ptr, L"(VFW)") == NULL) &&
           lstrlenW(str_ptr) < name_length ||
           (!(LowerCaseEqualsASCII(str_ptr, str_ptr + name_length,
                                   kGoogleCameraAdapter)))) {
         std::string id;
         std::string device_name(base::SysWideToUTF8(str_ptr));
         name.Reset();
         hr = prop_bag->Read(L"DevicePath", name.Receive(), 0);
         if (FAILED(hr) || name.type() != VT_BSTR) {
           id = device_name;
         } else {
           DCHECK_EQ(name.type(), VT_BSTR);
           id = base::SysWideToUTF8(V_BSTR(&name));
         }
 
         device_names->push_back(Name(device_name, id, Name::DIRECT_SHOW));
       }
     }
     moniker.Release();
   }
 }
 
 // static
 void VideoCaptureDeviceWin::GetDeviceSupportedFormats(const Name& device,
     VideoCaptureFormats* formats) {
-  NOTIMPLEMENTED();
+  DVLOG(1) << "GetDeviceSupportedFormats for " << device.name();
+  ScopedComPtr<ICreateDevEnum> dev_enum;
+  HRESULT hr = dev_enum.CreateInstance(CLSID_SystemDeviceEnum, NULL,
+                                       CLSCTX_INPROC);
+  if (FAILED(hr))
+    return;
+
+  ScopedComPtr<IEnumMoniker> enum_moniker;
+  hr = dev_enum->CreateClassEnumerator(CLSID_VideoInputDeviceCategory,
+                                       enum_moniker.Receive(), 0);
+  // CreateClassEnumerator returns S_FALSE on some Windows OS when no camera
+  // exists. Therefore the FAILED macro can't be used.
+  if (hr != S_OK)
+    return;
+
+  // Walk the capture devices. No need to check for "google camera adapter".

[tommi (sloooow) - chröme, 2014/02/17 12:58:29]

maybe elaborate on why not?

[mcasas, 2014/02/17 14:56:20]

Done.

+  ScopedComPtr<IMoniker> moniker;
+  int index = 0;
+  ScopedVariant device_id;
+  while (enum_moniker->Next(1, moniker.Receive(), NULL) == S_OK) {
+    ScopedComPtr<IPropertyBag> prop_bag;
+    hr = moniker->BindToStorage(0, 0, IID_IPropertyBag, prop_bag.ReceiveVoid());
+    if (FAILED(hr)) {
+      moniker.Release();
+      continue;
+    }
+
+    device_id.Reset();
+    hr = prop_bag->Read(L"DevicePath", device_id.Receive(), 0);
+    if (FAILED(hr)) {
+      DVLOG(1) << "Couldn't read a device's DevicePath.";
+      return;
+    }
+    if (device.id() == base::SysWideToUTF8(V_BSTR(&device_id)))
+      break;
+    moniker.Release();
+  }
+
+  if (moniker.get()) {
+    base::win::ScopedComPtr<IBaseFilter> capture_filter;
+    hr = GetDeviceFilter(device, capture_filter.Receive());
+    if (!capture_filter) {
+      DVLOG(2) << "Failed to create capture filter.";
+      return;
+    }
+
+    base::win::ScopedComPtr<IPin> output_capture_pin;
+    hr = GetPin(capture_filter, PINDIR_OUTPUT, PIN_CATEGORY_CAPTURE,
+                output_capture_pin.Receive());
+    if (!output_capture_pin) {
+      DVLOG(2) << "Failed to get capture output pin";
+      return;
+    }
+
+    ScopedComPtr<IAMStreamConfig> stream_config;
+    hr = output_capture_pin.QueryInterface(stream_config.Receive());
+    if (FAILED(hr)) {
+      DVLOG(2) << "Failed to get IAMStreamConfig interface from "
+                  "capture device";
+      return;
+    }
+
+    int count, size;
+    hr = stream_config->GetNumberOfCapabilities(&count, &size);
+    if (FAILED(hr)) {
+      DVLOG(2) << "Failed to GetNumberOfCapabilities";
+      return;
+    }
+
+    AM_MEDIA_TYPE* media_type = NULL;
+    VIDEO_STREAM_CONFIG_CAPS caps;
+    for (int i = 0; i < count; ++i) {
+      hr = stream_config->GetStreamCaps(i, &media_type,
+                                        reinterpret_cast<BYTE*>(&caps));
+      // GetStreamCaps() may return S_FALSE, so don't use FAILED() or SUCCEED()
+      // macros here since they'll trigger incorrectly.
+      if (hr != S_OK) {
+        DVLOG(2) << "Failed to GetStreamCaps";
+        return;
+      }
+
+      if (media_type->majortype == MEDIATYPE_Video &&
+          media_type->formattype == FORMAT_VideoInfo) {
+          VIDEOINFOHEADER* h =
+              reinterpret_cast<VIDEOINFOHEADER*>(media_type->pbFormat);
+          VideoCaptureFormat format;
+          format.frame_size.SetSize(h->bmiHeader.biWidth,
+                                    h->bmiHeader.biHeight);
+          // Trust the frame rate from the VIDEOINFOHEADER.
+          format.frame_rate = (h->AvgTimePerFrame > 0)
+              ? static_cast<int>(kSecondsToReferenceTime / h->AvgTimePerFrame)

[tommi (sloooow) - chröme, 2014/02/17 12:58:29]

nit: I think the convention is to have the operator last in line and not first.
<cond> ?
Foo() :
Bar();

[mcasas, 2014/02/17 14:56:20]

Done.

+              : 0;
+          format.pixel_format =
+              TranslateMediaSubtypeToPixelFormat(media_type->subtype);
+          formats->push_back(format);
+          DVLOG(1) << device.name() << " resolution: "
+               << format.frame_size.ToString() << ", fps: " << format.frame_rate
+               << ", pixel format: " << format.pixel_format;
+      }
+    }
+  }
 }
 
 VideoCaptureDeviceWin::VideoCaptureDeviceWin(const Name& device_name)
     : device_name_(device_name),
       state_(kIdle) {
   DetachFromThread();
 }
 
 VideoCaptureDeviceWin::~VideoCaptureDeviceWin() {
   DCHECK(CalledOnValidThread());
@@ skipping 278 matching lines @@
       capability.supported_format.frame_rate =
           (time_per_frame > 0)
               ? static_cast<int>(kSecondsToReferenceTime / time_per_frame)
               : 0;
 
       // DirectShow works at the moment only on integer frame_rate but the
       // best capability matching class works on rational frame rates.
       capability.frame_rate_numerator = capability.supported_format.frame_rate;
       capability.frame_rate_denominator = 1;
 
-      // We can't switch MEDIATYPE :~(.
-      if (media_type->subtype == kMediaSubTypeI420) {
-        capability.supported_format.pixel_format = PIXEL_FORMAT_I420;
-      } else if (media_type->subtype == MEDIASUBTYPE_IYUV) {
-        // This is identical to PIXEL_FORMAT_I420.
-        capability.supported_format.pixel_format = PIXEL_FORMAT_I420;
-      } else if (media_type->subtype == MEDIASUBTYPE_RGB24) {
-        capability.supported_format.pixel_format = PIXEL_FORMAT_RGB24;
-      } else if (media_type->subtype == MEDIASUBTYPE_YUY2) {
-        capability.supported_format.pixel_format = PIXEL_FORMAT_YUY2;
-      } else if (media_type->subtype == MEDIASUBTYPE_MJPG) {
-        capability.supported_format.pixel_format = PIXEL_FORMAT_MJPEG;
-      } else if (media_type->subtype == MEDIASUBTYPE_UYVY) {
-        capability.supported_format.pixel_format = PIXEL_FORMAT_UYVY;
-      } else if (media_type->subtype == MEDIASUBTYPE_ARGB32) {
-        capability.supported_format.pixel_format = PIXEL_FORMAT_ARGB;
-      } else {
-        WCHAR guid_str[128];
-        StringFromGUID2(media_type->subtype, guid_str, arraysize(guid_str));
-        DVLOG(2) << "Device supports (also) an unknown media type " << guid_str;
-        continue;
-      }
+      capability.supported_format.pixel_format =
+          TranslateMediaSubtypeToPixelFormat(media_type->subtype);
       capabilities_.Add(capability);
     }
     DeleteMediaType(media_type);
     media_type = NULL;
   }
 
   return !capabilities_.empty();
 }
 
 void VideoCaptureDeviceWin::SetErrorState(const std::string& reason) {
   DCHECK(CalledOnValidThread());
   DVLOG(1) << reason;
   state_ = kError;
   client_->OnError(reason);
 }
 }  // namespace media