Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1565803002: Sync Mac scopers with upstream Chromium (Closed)

Created:
4 years, 11 months ago by Mark Mentovai
Modified:
4 years, 11 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/mini_chromium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Sync Mac scopers with upstream Chromium This brings the following upstream changes into mini_chromium: e7259757073d Add an InvalidValue() member to base::ScopedTypeRefTraits cfd6ed5600d8 Rewrite most of the scopers in //base/mac to use ScopedTypeRef or ScopedGeneric R=rsesek@chromium.org Committed: https://chromium.googlesource.com/chromium/mini_chromium/+/a43fee120b10ed71df4e55a370948ca461d78232

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -338 lines) Patch
M base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M base/mac/scoped_cftyperef.h View 1 chunk +14 lines, -86 lines 0 comments Download
M base/mac/scoped_ioobject.h View 1 chunk +13 lines, -52 lines 0 comments Download
M base/mac/scoped_launch_data.h View 1 chunk +13 lines, -63 lines 0 comments Download
M base/mac/scoped_nsobject.h View 2 chunks +27 lines, -137 lines 0 comments Download
A base/mac/scoped_typeref.h View 1 chunk +86 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Mark Mentovai
4 years, 11 months ago (2016-01-06 16:20:55 UTC) #2
Robert Sesek
LGTM
4 years, 11 months ago (2016-01-06 17:19:30 UTC) #3
Mark Mentovai
4 years, 11 months ago (2016-01-06 17:23:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a43fee120b10ed71df4e55a370948ca461d78232 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698