Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 15658009: Fix a type mismatch on Windows caused by r201738. (Closed)

Created:
7 years, 6 months ago by ddorwin
Modified:
7 years, 6 months ago
Reviewers:
Lei Zhang, xhwang
CC:
chromium-reviews
Visibility:
Public.

Description

Fix a type mismatch on Windows caused by r201738. The problem was at encrypted_media_browsertest.cc line 167, which is a call to RegisterPepperCdm(), but the right fix is to use ASCII for the constants. TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M chrome/browser/component_updater/widevine_cdm_component_installer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/chrome_paths.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/widevine/cdm/widevine_cdm_common.h View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ddorwin
7 years, 6 months ago (2013-05-28 15:56:56 UTC) #1
xhwang
lgtm
7 years, 6 months ago (2013-05-28 15:57:47 UTC) #2
ddorwin
Committed patchset #1 manually as r202598 (presubmit successful).
7 years, 6 months ago (2013-05-28 17:49:15 UTC) #3
Lei Zhang
7 years, 6 months ago (2013-05-28 21:10:18 UTC) #4
Message was sent while issue was closed.
lgtm++

Powered by Google App Engine
This is Rietveld 408576698