Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 15658004: Split FileAPI code for common|common_child|renderer (Closed)

Created:
7 years, 7 months ago by kinuko
Modified:
7 years, 7 months ago
CC:
chromium-reviews, vsevik, nkostylev+watch_chromium.org, benjhayden+dwatch_chromium.org, tfarina, jam, yurys, joi+watch-content_chromium.org, Aaron Boodman, rginda+watch_chromium.org, darin-cc_chromium.org, pfeldman, oshima+watch_chromium.org, tzik+watch_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_, stevenjb+watch_chromium.org, kinuko+watch, davemoore+watch_chromium.org
Visibility:
Public.

Description

Split FileAPI code for common|common_child|renderer Move following files from content/common to content/common_child: - webfilesystem_callback_adapters.* - webfilesystem_impl.* - webfilewriter_impl.* Move following files from webkit/fileapi to webkit/common/fileapi: - directory_entry.h - file_system_types.h - file_system_url* - file_system_util* Move following files from webkit/fileapi to webkit/renderer/fileapi: - webfilewriter_base* BUG=239710 R=jamesr,michaeln TBR=avi,thestig Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202501

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : rebase2 #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -2096 lines) Patch
M chrome/browser/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_file_system_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_file_system_helper.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_proxy.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_task_executor.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/external_filesystem_apitest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_handler_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_event_router.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_file_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/platform_app_launcher.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes/itunes_file_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.cc View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/picasa/picasa_file_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/linux/mtp_device_task_helper.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/media_file_system_registry.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service_mock_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_metadata_store.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/remote_change_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/file_system_natives.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/media_galleries_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/sync_file_system_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/fileapi_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/fileapi/file_system_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/fileapi/file_system_messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
D content/common/fileapi/webfilesystem_callback_adapters.h View 1 chunk +0 lines, -48 lines 0 comments Download
D content/common/fileapi/webfilesystem_callback_adapters.cc View 1 chunk +0 lines, -77 lines 0 comments Download
D content/common/fileapi/webfilesystem_impl.h View 1 chunk +0 lines, -69 lines 0 comments Download
D content/common/fileapi/webfilesystem_impl.cc View 1 chunk +0 lines, -144 lines 0 comments Download
D content/common/fileapi/webfilewriter_impl.h View 1 chunk +0 lines, -35 lines 0 comments Download
D content/common/fileapi/webfilewriter_impl.cc View 1 chunk +0 lines, -51 lines 0 comments Download
A + content/common_child/fileapi/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/common_child/fileapi/webfilesystem_callback_adapters.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/common_child/fileapi/webfilesystem_callback_adapters.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/common_child/fileapi/webfilesystem_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/common_child/fileapi/webfilesystem_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/common_child/fileapi/webfilewriter_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/common_child/fileapi/webfilewriter_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M content/content_common_child.gypi View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_file_system_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/worker/websharedworker_stub.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/worker/websharedworkerclient_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/async_file_test_helper.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/async_file_test_helper.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/async_file_util.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/async_file_util_adapter.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/copy_or_move_file_validator_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/cross_operation_delegate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/dump_file_system.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/external_mount_points.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_context.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_context.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_dir_url_request_job.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_mount_point_provider.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_operation.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_quota_client.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_quota_client.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_quota_client_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_quota_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_url.h View 1 2 3 2 chunks +6 lines, -5 lines 0 comments Download
M webkit/browser/fileapi/file_system_url.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_url_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/isolated_context.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/isolated_mount_point_provider.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/local_file_system_cross_operation_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_system_operation.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/local_file_system_operation_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_system_operation_write_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_util.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/local_file_util_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/mount_points.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_database_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_directory_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_directory_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_stream_writer.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_stream_writer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_test_helper.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_test_helper.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_mount_point_provider.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/sandbox_mount_point_provider_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_origin_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_origin_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_quota_observer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/test_mount_point_provider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
A + webkit/common/fileapi/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/common/fileapi/directory_entry.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/common/fileapi/file_system_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/common/fileapi/file_system_util.h View 1 2 4 chunks +6 lines, -5 lines 0 comments Download
A + webkit/common/fileapi/file_system_util.cc View 1 2 2 chunks +1 line, -6 lines 0 comments Download
A + webkit/common/fileapi/file_system_util_unittest.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
A webkit/common/fileapi/webkit_common_fileapi.gypi View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M webkit/common/webkit_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/dom_storage/dom_storage_area.cc View 2 chunks +1 line, -1 line 0 comments Download
D webkit/fileapi/directory_entry.h View 1 chunk +0 lines, -24 lines 0 comments Download
D webkit/fileapi/file_system_types.h View 1 chunk +0 lines, -110 lines 0 comments Download
D webkit/fileapi/file_system_util.h View 1 2 1 chunk +0 lines, -148 lines 0 comments Download
D webkit/fileapi/file_system_util.cc View 1 2 1 chunk +0 lines, -361 lines 0 comments Download
D webkit/fileapi/file_system_util_unittest.cc View 1 2 3 1 chunk +0 lines, -203 lines 0 comments Download
M webkit/fileapi/syncable/canned_syncable_file_system.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/fileapi/syncable/local_file_change_tracker.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/syncable/local_file_sync_context.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/syncable/syncable_file_system_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/syncable/syncable_file_system_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/syncable/syncable_file_system_util_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D webkit/fileapi/webfilewriter_base.h View 1 chunk +0 lines, -71 lines 0 comments Download
D webkit/fileapi/webfilewriter_base.cc View 1 chunk +0 lines, -154 lines 0 comments Download
D webkit/fileapi/webfilewriter_base_unittest.cc View 1 chunk +0 lines, -411 lines 0 comments Download
M webkit/fileapi/webkit_fileapi.gypi View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_file_ref_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webkit/renderer/fileapi/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/renderer/fileapi/webfilewriter_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/renderer/fileapi/webfilewriter_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webkit/renderer/fileapi/webfilewriter_base_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/storage/webkit_storage.gypi View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/simple_file_system.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/simple_file_system.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/simple_file_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/simple_file_writer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
michaeln
https://codereview.chromium.org/15658004/diff/13001/content/content_common.gypi File content/content_common.gypi (left): https://codereview.chromium.org/15658004/diff/13001/content/content_common.gypi#oldcode173 content/content_common.gypi:173: 'common/fileapi/webblobregistry_impl.h', i've got the webblobregistry moving in the works ...
7 years, 7 months ago (2013-05-24 20:41:58 UTC) #1
jamesr
https://codereview.chromium.org/15658004/diff/13001/webkit/renderer/webkit_renderer_storage.gypi File webkit/renderer/webkit_renderer_storage.gypi (right): https://codereview.chromium.org/15658004/diff/13001/webkit/renderer/webkit_renderer_storage.gypi#newcode1 webkit/renderer/webkit_renderer_storage.gypi:1: # Copyright 2013 The Chromium Authors. All rights reserved. ...
7 years, 7 months ago (2013-05-24 20:46:25 UTC) #2
kinuko
Sorry, the change wasn't ready for review... (now it is). I've realized that I can't ...
7 years, 7 months ago (2013-05-27 08:08:48 UTC) #3
jamesr
lgtm
7 years, 7 months ago (2013-05-27 23:33:21 UTC) #4
kinuko
TBR-ing thestig@ and avi@ for chrome/ and content/ changes. Thx,
7 years, 7 months ago (2013-05-28 02:10:13 UTC) #5
kinuko
7 years, 7 months ago (2013-05-28 04:59:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #6 manually as r202501.

Powered by Google App Engine
This is Rietveld 408576698