Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1565783004: Merge to XFA: Fix a GetFileContents() call that should have been in commit aa326bd6. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Fix a GetFileContents() call that should have been in commit aa326bd6. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1568763003 . (cherry picked from commit 0213958bf66e839f132d9dea531d2627091c3cbe) Committed: https://pdfium.googlesource.com/pdfium/+/bcc03a4d8340d06c013a8e7bc5f11be4e820bb41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M testing/test_support.cpp View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
TBR x 2
4 years, 11 months ago (2016-01-07 08:47:57 UTC) #1
Lei Zhang
Committed patchset #1 (id:1) manually as bcc03a4d8340d06c013a8e7bc5f11be4e820bb41 (presubmit successful).
4 years, 11 months ago (2016-01-07 08:48:05 UTC) #3
Tom Sepez
4 years, 11 months ago (2016-01-07 16:54:59 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698