Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1565783002: Revert of Determine a layer's IsAffectedByPageScale property without using Layer Tree (Closed)

Created:
4 years, 11 months ago by sunxd
Modified:
4 years, 11 months ago
Reviewers:
ajuma, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Determine a layer's IsAffectedByPageScale property without using Layer Tree (patchset #2 id:20001 of https://codereview.chromium.org/1544103002/ ) Reason for revert: Revert the CL to see if it causes an improvement on the waterfall. Related to Issue 573267: 10.3% regression in blink_perf.layout at 367076:367083. Original issue's description: > Determine a layer's IsAffectedByPageScale property without using Layer Tree. > > The property is retrieved from TransformTree; > Fix the order of updating the page scale layer and adding transform tree node; > Fix the problem that transform tree sequence number not correctly updated for mask layers; > Fix related cc unit tests where a property tree was not created. > > BUG=568777 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/73c0fa89da59c8ea5e0d86d1136d7c1a7e68e097 > Cr-Commit-Position: refs/heads/master@{#367083} BUG=568777, 573267 Committed: https://crrev.com/42238faf73f0d108a6a926f3fddf35887df071a1 Cr-Commit-Position: refs/heads/master@{#367837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -43 lines) Patch
M cc/layers/heads_up_display_layer_impl_unittest.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M cc/layers/layer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/layers/layer_impl.h View 1 chunk +4 lines, -1 line 0 comments Download
M cc/layers/layer_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M cc/layers/picture_image_layer_impl_unittest.cc View 3 chunks +12 lines, -16 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
sunxd
Created Revert of Determine a layer's IsAffectedByPageScale property without using Layer Tree
4 years, 11 months ago (2016-01-06 15:30:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565783002/1
4 years, 11 months ago (2016-01-06 15:30:26 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 11 months ago (2016-01-06 15:30:27 UTC) #4
ajuma
On 2016/01/06 15:30:27, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 11 months ago (2016-01-06 15:42:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565783002/1
4 years, 11 months ago (2016-01-06 15:42:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 16:43:01 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 16:44:18 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42238faf73f0d108a6a926f3fddf35887df071a1
Cr-Commit-Position: refs/heads/master@{#367837}

Powered by Google App Engine
This is Rietveld 408576698