Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1565763002: [Android] Revise devil handling of host platforms. (Closed)

Created:
4 years, 11 months ago by jbudorick
Modified:
4 years, 11 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Revise devil handling of host platforms. This is NOPRESUBMIT because I've locked down devil for the move to catapult via presubmit. That's the only presubmit failure. BUG=574568 NOPRESUBMIT=true Committed: https://crrev.com/da062ad1f4876168012e3834f2f3eb187c6a8f45 Cr-Commit-Position: refs/heads/master@{#367826}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M build/android/devil/devil_dependencies.json View 9 chunks +12 lines, -12 lines 0 comments Download
M build/android/devil/devil_env.py View 2 chunks +3 lines, -3 lines 1 comment Download
M build/android/devil/devil_env_test.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/devil_chromium.json View 6 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
4 years, 11 months ago (2016-01-06 14:38:09 UTC) #2
rnephew (Reviews Here)
On 2016/01/06 14:38:09, jbudorick wrote: rubber stamp lgtm because I assume there is a good ...
4 years, 11 months ago (2016-01-06 14:54:52 UTC) #3
jbudorick
https://codereview.chromium.org/1565763002/diff/1/build/android/devil/devil_env.py File build/android/devil/devil_env.py (right): https://codereview.chromium.org/1565763002/diff/1/build/android/devil/devil_env.py#newcode142 build/android/devil/devil_env.py:142: return '%s_%s' % (sys.platform, platform.machine()) This is why. Mac ...
4 years, 11 months ago (2016-01-06 14:56:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1565763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1565763002/1
4 years, 11 months ago (2016-01-06 15:04:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 15:46:22 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 15:47:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da062ad1f4876168012e3834f2f3eb187c6a8f45
Cr-Commit-Position: refs/heads/master@{#367826}

Powered by Google App Engine
This is Rietveld 408576698